LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked.html - Issue 311033003: Implementing mixed content for forms posting to insecure location from secure ones

Unified Diff: LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked.html

Issue 311033003: Implementing mixed content for forms posting to insecure location from secure ones (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding mixed content to forms submitting to non-secure location from a secure one Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-allowed.html ('K') | « LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-allowed-expected.txt ('k') | LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked-expected.txt » ('j') | Source/core/html/HTMLFormElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked.html

diff --git a/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html b/LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked.html

similarity index 53%

copy from LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

copy to LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked.html

index 88175fa3cbc5f39b891ce60a081c06049f8e3a31..8bfbaf994ccbaaa2f9d8294986a99f0c1c898518 100644

--- a/LayoutTests/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

+++ b/LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked.html

@@ -7,20 +7,18 @@ if (window.testRunner) {

testRunner.setCanOpenWindows();

testRunner.setCloseRemainingWindowsWhenComplete(true);

testRunner.overridePreference("WebKitAllowDisplayingInsecureContent", false);

- testRunner.setAllowDisplayOfInsecureContent(true);

}

window.addEventListener("message", function (e) {

- if (window.testRunner)

- testRunner.notifyDone();

+ if (window.testRunner)

jww 2014/06/05 03:49:46 Extra spaces before lines 13 & 14.

mhm 2014/06/05 17:04:28 Done.

+ testRunner.notifyDone();

}, false);

</script>

-<p>This test opens a window that loads an insecure image. We should trigger

-a mixed content callback even though we've set the preference to block this,

-because we've overriden the preference via a web permission client callback.</p>

+<p>This test opens a window that show a form with "action" pointing to insecure

jww 2014/06/05 03:49:46 sp: Should be "...that shows..." and "...to an ins

mhm 2014/06/05 17:04:28 Done.

+location. We should not trigger a mixed content callback even though the main frame in the window is HTTPS and the form is pointing to insecure content, because we've set the preference to block this.</p>

-window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-image.html");

+window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-formSubmission.html");

</script>

</body>

</html>