Implementing mixed content for forms posting to insecure location from secure ones

Source/core/html/HTMLFormElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 100 matching lines @@
     DEFINE_ATTRIBUTE_EVENT_LISTENER(autocomplete);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(autocompleteerror);
 
     RadioButtonGroupScope& radioButtonGroupScope() { return m_radioButtonGroupScope; }
 
     const FormAssociatedElement::List& associatedElements() const;
     const WillBeHeapVector<RawPtrWillBeMember<HTMLImageElement> >& imageElements();
 
     void anonymousNamedGetter(const AtomicString& name, bool&, RefPtrWillBeRawPtr<RadioNodeList>&, bool&, RefPtrWillBeRawPtr<Element>&);
 
+protected:
+    virtual void attributeChanged(const QualifiedName&, const AtomicString&, AttributeModificationReason = ModifiedDirectly) OVERRIDE;
+
 private:
     explicit HTMLFormElement(Document&);
 
     virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE;
     virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
     virtual void removedFrom(ContainerNode*) OVERRIDE;
     virtual void finishParsingChildren() OVERRIDE;
 
     virtual void handleLocalEvents(Event*) OVERRIDE;
 
@@ skipping 44 matching lines @@
     bool m_hasElementsAssociatedByParser;
     bool m_didFinishParsingChildren;
 
     bool m_wasUserSubmitted;
 
     bool m_isInResetFunction;
 
     bool m_wasDemoted;
 
     OwnPtr<GenericEventQueue> m_pendingAutocompleteEventsQueue;
+
+    KURL getActionURL() const

[Mike West, 2014/06/06 12:18:18]

We're only using this in the method you introduced, correct? If so, let's not
add to the external signature. I'd prefer to see you implement this as a static
method in the .cc file.

[mhm, 2014/06/06 19:11:59]

Done.

+    {
+        return document().completeURL(m_attributes.action().isEmpty() ? document().url().string() : m_attributes.action());

[Mike West, 2014/06/06 12:18:18]

Why convert the document's URL into a string, and then convert it into a URL?
Just return the document's URL if `action` is empty, and call `completeURL` on
the attribute if it's not empty.

(Sorry. I should have mentioned both of these in the initial review. I didn't
pay enough attention at the time.)

[mhm, 2014/06/06 19:11:59]

Done.

+    }
 };
 
 } // namespace WebCore
 
 #endif // HTMLFormElement_h