sdk/lib/_internal/pub/lib/src/barback/barback_server.dart - Issue 311003002: Add instrumentation for tracking how long it takes barback to start.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/barback_server.dart

Issue 311003002: Add instrumentation for tracking how long it takes barback to start. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart ('k') | sdk/lib/_internal/pub/lib/src/log.dart » ('j') | sdk/lib/_internal/pub/lib/src/log.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/barback_server.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart b/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart

index d53d3eafbcd5dfbf87180b812191860dcd4e119c..340b4a28f05842acb930afba6daff8b7b61548f9 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/barback_server.dart

@@ -101,9 +101,7 @@ class BarbackServer extends BaseServer<BarbackServerResult> {

asset: id);

}

- logRequest(request, "Loading $id");

return environment.barback.getAssetById(id).then((result) {

- logRequest(request, "getAssetById($id) returned");

return result;

}).then((asset) => _serveAsset(request, asset)).catchError((error, trace) {

if (error is! AssetNotFoundException) throw error;