Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: chrome/browser/sync/glue/extension_change_processor.h

Issue 3110008: Massive refactoring of extensions sync code (Closed) Base URL: 76.121.192.83:~/projects/chromium/src
Patch Set: Fixed compile error Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/extension_change_processor.h
diff --git a/chrome/browser/sync/glue/extension_change_processor.h b/chrome/browser/sync/glue/extension_change_processor.h
index 43c6a8fe2f09e1f4d7a91b0e36cbff688493c7db..b118904de3472619873b9762fd343e630d1ab4b6 100644
--- a/chrome/browser/sync/glue/extension_change_processor.h
+++ b/chrome/browser/sync/glue/extension_change_processor.h
@@ -9,17 +9,18 @@
#include "base/basictypes.h"
#include "chrome/browser/sync/engine/syncapi.h"
#include "chrome/browser/sync/glue/change_processor.h"
+#include "chrome/browser/sync/glue/extension_sync_traits.h"
#include "chrome/common/notification_observer.h"
#include "chrome/common/notification_type.h"
#include "chrome/common/notification_registrar.h"
+class ExtensionsService;
class NotificationDetails;
class NotificationSource;
class Profile;
namespace browser_sync {
-class ExtensionModelAssociator;
class UnrecoverableErrorHandler;
// This class is responsible for taking changes from the
@@ -29,13 +30,9 @@ class UnrecoverableErrorHandler;
class ExtensionChangeProcessor : public ChangeProcessor,
public NotificationObserver {
public:
- // Does not take ownership of either argument.
- //
- // TODO(akalin): Create a Delegate interface and take that instead.
- // That'll enable us to unit test this class.
- ExtensionChangeProcessor(
- UnrecoverableErrorHandler* error_handler,
- ExtensionModelAssociator* extension_model_associator);
+ // Does not take ownership of |error_handler|.
+ explicit ExtensionChangeProcessor(
+ UnrecoverableErrorHandler* error_handler);
virtual ~ExtensionChangeProcessor();
// NotificationObserver implementation.
@@ -60,8 +57,8 @@ class ExtensionChangeProcessor : public ChangeProcessor,
void StartObserving();
void StopObserving();
- ExtensionModelAssociator* extension_model_associator_;
NotificationRegistrar notification_registrar_;
+ const ExtensionSyncTraits traits_;
// Owner of the ExtensionService. Non-NULL iff |running()| is true.
Profile* profile_;
« no previous file with comments | « chrome/browser/extensions/extensions_service.cc ('k') | chrome/browser/sync/glue/extension_change_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698