Massive refactoring of extensions sync code

chrome/browser/sync/glue/extension_util.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_EXTENSION_UTIL_H_
 #define CHROME_BROWSER_SYNC_GLUE_EXTENSION_UTIL_H_
 #pragma once
 
+// This file contains some low-level utility functions used by
+// extensions sync.
+
+#include <set>
 #include <string>
 
 class Extension;
+class ExtensionTypeSet;
 class ExtensionsService;
 
 namespace sync_pb {
 class ExtensionSpecifics;
 }  // sync_pb
 
 namespace browser_sync {
 
+enum ExtensionType {
+  THEME,
+  EXTENSION,
+  USER_SCRIPT,
+  APP,
+};
+
+typedef std::set<ExtensionType> ExtensionTypeSet;
+
+// Returns the type of the given extension.
+//
+// TODO(akalin): Might be useful to move this into extension.cc.
+ExtensionType GetExtensionType(const Extension& extension);
+
 // Returns whether or not the given extension is one we want to sync.
-bool IsExtensionSyncable(const Extension& extension);
+bool IsExtensionValid(const Extension& extension);
+
+// Returns whether or not the given extension is one we want to sync.
+bool IsExtensionValidAndSyncable(const Extension& extension,
+                                 const ExtensionTypeSet& allowed_types);
 
 // Stringifies the given ExtensionSpecifics.
 std::string ExtensionSpecificsToString(
     const sync_pb::ExtensionSpecifics& specifics);
 
 // Returns whether or not the values of the given specifics are valid,
 // in particular the id, version, and update URL.
 bool IsExtensionSpecificsValid(
     const sync_pb::ExtensionSpecifics& specifics);
 
@@ skipping 72 matching lines @@
 // user properties if |merge_user_properties| is set) if |specifics|
 // has a more recent or the same version as |merged_specifics|.
 void MergeExtensionSpecifics(
     const sync_pb::ExtensionSpecifics& specifics,
     bool merge_user_properties,
     sync_pb::ExtensionSpecifics* merged_specifics);
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_EXTENSION_UTIL_H_