Issue 310973003: Fix leak with SharedBitmaps allocated by new[]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 310973003: Fix leak with SharedBitmaps allocated by new[] (Closed)

Created:
6 years, 6 months ago by jbauman

Modified:
6 years, 6 months ago

Reviewers:
piman

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix leak with SharedBitmaps allocated by new[] The handle_map_ was holding onto them, so they weren't being released. Instead, they should be removed from the map whenever that first SharedBitmap that was created is destroyed. BUG=362924 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274765

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	content/common/host_shared_bitmap_manager.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/common/host_shared_bitmap_manager.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/310973003/1

6 years, 6 months ago (2014-06-03 23:33:44 UTC) #2

Message was sent while issue was closed.

Change committed as 274765