Move GCMClient related files to gcm_driver component

Move GCMClient related files to gcm_driver component

GCMActivity, GCMClient, GCMClientImpl and GCMStatsRecorderImpl have been moved to gcm_driver component. This allows us to remove the dependency on google_apis/gcm for Android GCM support.

BUG=353786, 356716
TEST=existing tests due to no functionality change
R=fgorski@chromium.org, zea@chromium.org
TBR=arv@chromium.org, kalman@chromium.org, pavely@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275826

[Nicolas Zea, 2014-06-03 23:22:47]

https://codereview.chromium.org/310973002/diff/1/google_apis/gcm/gcm.gyp
File google_apis/gcm/gcm.gyp (left):

https://codereview.chromium.org/310973002/diff/1/google_apis/gcm/gcm.gyp#oldc...
google_apis/gcm/gcm.gyp:78: 'monitoring/gcm_stats_recorder.h',
what about the stats recorder interface?

[jianli, 2014-06-03 23:26:01]

https://codereview.chromium.org/310973002/diff/1/google_apis/gcm/gcm.gyp
File google_apis/gcm/gcm.gyp (left):

https://codereview.chromium.org/310973002/diff/1/google_apis/gcm/gcm.gyp#oldc...
google_apis/gcm/gcm.gyp:78: 'monitoring/gcm_stats_recorder.h',
On 2014/06/03 23:22:47, Nicolas Zea wrote:
> what about the stats recorder interface?

GCMStatsRecorder interface can't be moved to gcm_driver component because a
bunch of google_apis/gcm files needs to refer to this interface and we can't let
google_apis/gcm files depend on components/gcm_driver.

[fgorski, 2014-06-03 23:27:49]

lgtm with a few minor comments.

I assume there are going to be a few more files left to be moved after this
change?

https://codereview.chromium.org/310973002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcm/gcm_api.h (right):

https://codereview.chromium.org/310973002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcm/gcm_api.h:1: // Copyright 2013 The Chromium
Authors. All rights reserved.
2014?

https://codereview.chromium.org/310973002/diff/1/components/gcm_driver/gcm_ap...
File components/gcm_driver/gcm_app_handler.h (right):

https://codereview.chromium.org/310973002/diff/1/components/gcm_driver/gcm_ap...
components/gcm_driver/gcm_app_handler.h:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
nit: drop the (c)

https://codereview.chromium.org/310973002/diff/1/components/gcm_driver/gcm_st...
File components/gcm_driver/gcm_stats_recorder_impl_unittest.cc (right):

https://codereview.chromium.org/310973002/diff/1/components/gcm_driver/gcm_st...
components/gcm_driver/gcm_stats_recorder_impl_unittest.cc:5: #include
"components/gcm_driver/gcm_stats_recorder_impl.h"
are we putting everything in a flat folder now?

[jianli, 2014-06-03 23:31:24]

This is the last major one. What is left is to move mcs_probe (if we still want)
and rename the gcm namespace.

https://codereview.chromium.org/310973002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcm/gcm_api.h (right):

https://codereview.chromium.org/310973002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcm/gcm_api.h:1: // Copyright 2013 The Chromium
Authors. All rights reserved.
On 2014/06/03 23:27:48, fgorski wrote:
> 2014?

Will fix.

https://codereview.chromium.org/310973002/diff/1/components/gcm_driver/gcm_ap...
File components/gcm_driver/gcm_app_handler.h (right):

https://codereview.chromium.org/310973002/diff/1/components/gcm_driver/gcm_ap...
components/gcm_driver/gcm_app_handler.h:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
On 2014/06/03 23:27:48, fgorski wrote:
> nit: drop the (c)

Indeed the presubmit script prefers adding (c).

https://codereview.chromium.org/310973002/diff/1/components/gcm_driver/gcm_st...
File components/gcm_driver/gcm_stats_recorder_impl_unittest.cc (right):

https://codereview.chromium.org/310973002/diff/1/components/gcm_driver/gcm_st...
components/gcm_driver/gcm_stats_recorder_impl_unittest.cc:5: #include
"components/gcm_driver/gcm_stats_recorder_impl.h"
On 2014/06/03 23:27:48, fgorski wrote:
> are we putting everything in a flat folder now?

Yes.

[Michael van Ouwerkerk, 2014-06-04 12:49:07]

Just a drive-by nit.

https://codereview.chromium.org/310973002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcm/gcm_api.h (right):

https://codereview.chromium.org/310973002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcm/gcm_api.h:1: // Copyright 2013 The Chromium
Authors. All rights reserved.
On 2014/06/03 23:27:48, fgorski wrote:
> 2014?

I don't think we update the copyright year when we edit a file.

[fgorski, 2014-06-04 14:52:14]

On 2014/06/04 12:49:07, Michael van Ouwerkerk wrote:
> Just a drive-by nit.
> 
>
https://codereview.chromium.org/310973002/diff/1/chrome/browser/extensions/ap...
> File chrome/browser/extensions/api/gcm/gcm_api.h (right):
> 
>
https://codereview.chromium.org/310973002/diff/1/chrome/browser/extensions/ap...
> chrome/browser/extensions/api/gcm/gcm_api.h:1: // Copyright 2013 The Chromium
> Authors. All rights reserved.
> On 2014/06/03 23:27:48, fgorski wrote:
> > 2014?
> 
> I don't think we update the copyright year when we edit a file.

In that case there is one other file that actually updates it and that should be
changed.

[Nicolas Zea, 2014-06-05 21:29:46]

lgtm

[jianli, 2014-06-06 17:07:16]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:08:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/310973002/60001

[commit-bot: I haz the power, 2014-06-06 17:28:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-06-06 17:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:30:58]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[jianli, 2014-06-06 17:52:56]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:53:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/310973002/100001

[commit-bot: I haz the power, 2014-06-06 18:21:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/13950)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/17064)

[commit-bot: I haz the power, 2014-06-06 18:24:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 18:24:26]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[jianli, 2014-06-06 20:12:33]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-06-06 20:15:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/310973002/120001

[jianli, 2014-06-06 21:16:40]

The CQ bit was unchecked by jianli@chromium.org

[jianli, 2014-06-06 21:16:53]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-06-06 21:17:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/310973002/120001

[jianli, 2014-06-06 21:58:00]

The CQ bit was unchecked by jianli@chromium.org

[jianli, 2014-06-06 22:05:27]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-06-06 22:06:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/310973002/140001

[jianli, 2014-06-07 00:33:56]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-06-07 00:36:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/310973002/160001

[commit-bot: I haz the power, 2014-06-07 05:08:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-06-07 05:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-07 05:12:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[jianli, 2014-06-09 17:13:15]

Committed patchset #7 manually as r275826 (presubmit successful).