Issue 310963002: Fix a possible race in WebViewTest.Shim_TestPartitionRaisesException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 310963002: Fix a possible race in WebViewTest.Shim_TestPartitionRaisesException. (Closed)

Created:
6 years, 6 months ago by lazyboy

Modified:
6 years, 6 months ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix a possible race in WebViewTest.Shim_TestPartitionRaisesException. We wait for loadstop to be fired so that we are sure that the <webview> has navigated. BUG=267304 Test=Test only change, nothing visible. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274790

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -17 lines)			Patch
	M	chrome/browser/apps/web_view_browsertest.cc	View		1 chunk	+2 lines, -13 lines	0 comments	Download
	M	chrome/test/data/extensions/platform_apps/web_view/shim/main.js	View		1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/310963002/1

6 years, 6 months ago (2014-06-04 03:16:39 UTC) #4

Message was sent while issue was closed.

Change committed as 274790

Expand Messages | Collapse Messages