Issue 32919: Update the Zoom NSMenuItems (Zoom-In/Zoom-out/Actual-Size) when the zoom state changes.

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 941 matching lines @@
 #endif
     find_helper->StartFinding(find_text, forward_direction, false);
   }
 }
 
 void Zoom(Browser* browser, content::PageZoom zoom) {
   chrome_page_zoom::Zoom(browser->tab_strip_model()->GetActiveWebContents(),
                          zoom);
 }
 
+bool CanZoomIn(content::WebContents *contents) {

[Ben Goodger (Google), 2014/06/05 15:45:03]

nit: WebContents* contents here, and in the subsequent 2 functions.

[sarka, 2014/06/05 19:55:05]

Done.

[sarka, 2014/06/05 19:55:05]

Done.

+  bool dummy = false;
+  return contents->GetZoomPercent(&dummy,
+    &dummy) == contents->GetMaximumZoomPercent() + 1 ? false : true;

[Ben Goodger (Google), 2014/06/05 15:45:03]

I'd write these as:

return contents->GetZoomPercent(&dummy, &dummy) !=
    contents->GetMaximumZoomPercent() + 1;

(note also the 4-space indent for wrapped lines).

[sarka, 2014/06/05 19:55:05]

Done.

+}
+
+bool CanZoomOut(content::WebContents *contents) {
+  bool dummy = false;
+  return contents->GetZoomPercent(&dummy,
+    &dummy) == contents->GetMinimumZoomPercent() ? false : true;
+}
+
+bool ActualSize(content::WebContents *contents) {
+  bool dummy = false;
+  return contents->GetZoomPercent(&dummy,
+    &dummy) == 100 ? false : true;
+}
+
+
 void FocusToolbar(Browser* browser) {
   content::RecordAction(UserMetricsAction("FocusToolbar"));
   browser->window()->FocusToolbar();
 }
 
 void FocusLocationBar(Browser* browser) {
   content::RecordAction(UserMetricsAction("FocusLocation"));
   browser->window()->SetFocusToLocationBar(true);
 }
 
@@ skipping 288 matching lines @@
                                           browser->profile(),
                                           browser->host_desktop_type()));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 
 }  // namespace chrome