Chromium Code Reviews
Help | Chromium Project | Sign in
(937)

Issue 3109016: bump up croscorefonts ebuild rev to 0.0.3. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Jungshik Shin
Modified:
2 years, 11 months ago
Reviewers:
anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, bstell, jlees
Base URL:
ssh://git@chromiumos-git/chromiumos-overlay.git
Visibility:
Public.

Description

bump up croscorefonts ebuild rev to 0.0.3.

This will pull in croscorefonts-0.0.3.tar.gz from the distfile storage. It has the 2010-07-30 version of Tinos with a much broader character repertoire and some hinting changes for the Windows-1252 portion

Arimo and Cousine remain the
same as in 0.0.2

BUG=5287
TEST=1. Pages with Times New Roman or '*, sans-serif' are rendered with
the 2010-07-30 version of Tinos.
2. In addition, Unicode characters in U+1E00 block (for Vietnamese) are rendered with Tinos instead of DejaVu Serif when serif font is used.
TBR=anush

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Lint Patch
A + media-fonts/croscorefonts/croscorefonts-0.0.3.ebuild View 1 chunk +1 line, -1 line 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Jungshik Shin
3 years, 8 months ago #1
anush
3 years, 8 months ago #2
LGTM

On Fri, Aug 13, 2010 at 1:04 PM, <jshin@chromium.org> wrote:

> Reviewers: anush,
>
> Description:
> bump up croscorefonts ebuild rev to 0.0.3.
>
> This will pull in croscorefonts-0.0.3.tar.gz from the distfile storage,
> which has the 2010-07-30 version of Tinos. Arimo and Cousine remain the
> same as in 0.0.2
>
> BUG=5287
> TEST=Pages with Times New Roman or '*, sans-serif' are rendered with
> the 2010-07-30 version of Tinos.
> TBR=anush
>
> Please review this at http://codereview.chromium.org/3109016/show
>
> SVN Base: ssh://git@chromiumos-git/chromiumos-overlay.git
>
> Affected files:
>  A + media-fonts/croscorefonts/croscorefonts-0.0.3.ebuild
>
>
> Index: media-fonts/croscorefonts/croscorefonts-0.0.3.ebuild
> diff --git a/media-fonts/croscorefonts/croscorefonts-0.0.1.ebuild
> b/media-fonts/croscorefonts/croscorefonts-0.0.3.ebuild
> similarity index 85%
> rename from media-fonts/croscorefonts/croscorefonts-0.0.1.ebuild
> rename to media-fonts/croscorefonts/croscorefonts-0.0.3.ebuild
> index
>
167d85c8100c9cd1bc3f6aa47b97b214fcd6103b..cd4cec5d51cc3375d0388572b46dce38d316c64a
> 100644
> --- a/media-fonts/croscorefonts/croscorefonts-0.0.1.ebuild
> +++ b/media-fonts/croscorefonts/croscorefonts-0.0.3.ebuild
> @@ -5,7 +5,7 @@
>  inherit font
>
>  DESCRIPTION="Arimo, Tinos and Cousine in 4 weights developed by Ascender
> for Chrom*OS"
> -SRC_URI="
>
http://build.chromium.org/mirror/chromiumos/localmirror/distfiles/${P}.tar.gz...
> "
> +SRC_URI="
>
http://commondatastorage.googleapis.com/chromeos-localmirror/distfiles/${P}.t...
> "
>
>  LICENSE="OFL-1.1"
>  SLOT="0"
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6