Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 3109006: Revert 55683 - Merge 65095 - Removing an element from an anonymous block caus... (Closed)

Created:
10 years, 4 months ago by Chris Guillory
Modified:
9 years, 7 months ago
Reviewers:
Chris Guillory
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 55683 - Merge 65095 - Removing an element from an anonymous block causes crash There's an error in the merge. I'll resubmitted with a new change that I've verified with a local build of the 472 branch. https://bugs.webkit.org/show_bug.cgi?id=42309 Reviewed by Dave Hyatt. WebCore: There was a case where a continuation was added as a child, but if you asked that child who is your parent, it would return the wrong answer. The specific scenario was when a sibling of an element who was the start of a continuation was present. Retrieving the parent object had then follow the sibling chain and then follow the originating continuation chain. Test: accessibility/removed-anonymous-block-child-causes-crash.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::nextSibling): Fix erroneous comment (WebCore::nextContinuation): (WebCore::AccessibilityRenderObject::renderParentObject): Handle unhandled continuation case. (WebCore::AccessibilityRenderObject::addChildren): ASSERT that the parentObject() is the same when adding a new child. LayoutTests: * accessibility/removed-anonymous-block-child-causes-crash-expected.txt: Added. * accessibility/removed-anonymous-block-child-causes-crash.html: Added. BUG=47126 TEST=accessibility/removed-anonymous-block-child-causes-crash.html TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/3176001 TBR=ctguil@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -128 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/accessibility/removed-anonymous-block-child-causes-crash.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/accessibility/removed-anonymous-block-child-causes-crash-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +0 lines, -25 lines 0 comments Download
M WebCore/accessibility/AccessibilityRenderObject.cpp View 5 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Chris Guillory
10 years, 4 months ago (2010-08-11 17:34:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698