Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 310873002: Reschedule COMPOSITE_EVENTUALLY instead of COMPOSITE_IMMEDIATELY if we miss a browser frame (Closed)

Created:
6 years, 6 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 6 months ago
Reviewers:
no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reschedule COMPOSITE_EVENTUALLY instead of COMPOSITE_IMMEDIATELY if we miss a browser frame If we miss a browser frame, reschedule a new COMPOSITE_EVENTUALL, there will be high latency/jank before the next composite happens, but this will keep the browser compositor and renderer compositor in sync (low latency mode). While if we COMPOSITOR_IMMEDIATELY, it could make the browser compositor always one frame behind renderer compositor (high latency mode). BUG=379264 TEST=record a trace for the following test: scroll on a simple page, first with top control hidden, then transit into showing the top control. With COMPOSITE_IMMEDIATELY, the latency graph shows that the scroll latency jumps up at the point of transition and stays at high latency mode. With COMPOSITE_EVENTUALL, the latency graph shows that the scroll latency jumps up at the point of transition but comes back to normal after. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274640

Patch Set 1 #

Total comments: 2

Patch Set 2 : add more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yufeng Shen (Slow to review)
6 years, 6 months ago (2014-06-03 16:18:16 UTC) #1
no sievers
LGTM. Thanks for looking into this! https://codereview.chromium.org/310873002/diff/1/content/browser/renderer_host/compositor_impl_android.cc File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/310873002/diff/1/content/browser/renderer_host/compositor_impl_android.cc#newcode685 content/browser/renderer_host/compositor_impl_android.cc:685: // We somehow ...
6 years, 6 months ago (2014-06-03 17:04:11 UTC) #2
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 6 months ago (2014-06-03 18:22:29 UTC) #3
Yufeng Shen (Slow to review)
https://codereview.chromium.org/310873002/diff/1/content/browser/renderer_host/compositor_impl_android.cc File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/310873002/diff/1/content/browser/renderer_host/compositor_impl_android.cc#newcode685 content/browser/renderer_host/compositor_impl_android.cc:685: // We somehow missed the last vsync interval, so ...
6 years, 6 months ago (2014-06-03 18:22:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/310873002/20001
6 years, 6 months ago (2014-06-03 18:23:30 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 21:50:38 UTC) #6
Message was sent while issue was closed.
Change committed as 274640

Powered by Google App Engine
This is Rietveld 408576698