Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: remoting/host/win/worker_process_launcher_unittest.cc

Issue 310853003: Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/win/worker_process_launcher_unittest.cc
diff --git a/remoting/host/win/worker_process_launcher_unittest.cc b/remoting/host/win/worker_process_launcher_unittest.cc
index 5503ab9ab763c8fec286432dc4f8b8efc5c1dcda..d5c885e3ff711f42ae42f9c70cd71a606359de49 100644
--- a/remoting/host/win/worker_process_launcher_unittest.cc
+++ b/remoting/host/win/worker_process_launcher_unittest.cc
@@ -273,11 +273,10 @@ void WorkerProcessLauncherTest::TerminateWorker(DWORD exit_code) {
}
void WorkerProcessLauncherTest::ConnectClient() {
- channel_client_.reset(new IPC::ChannelProxy(
- IPC::ChannelHandle(channel_name_),
- IPC::Channel::MODE_CLIENT,
- &client_listener_,
- task_runner_));
+ channel_client_ = IPC::ChannelProxy::Create(IPC::ChannelHandle(channel_name_),
+ IPC::Channel::MODE_CLIENT,
+ &client_listener_,
+ task_runner_);
// Pretend that |kLaunchSuccessTimeoutSeconds| passed since launching
// the worker process. This will make the backoff algorithm think that this
@@ -361,11 +360,8 @@ void WorkerProcessLauncherTest::DoLaunchProcess() {
ASSERT_TRUE(CreateIpcChannel(channel_name_, kIpcSecurityDescriptor, &pipe));
// Wrap the pipe into an IPC channel.
- channel_server_.reset(new IPC::ChannelProxy(
- IPC::ChannelHandle(pipe),
- IPC::Channel::MODE_SERVER,
- this,
- task_runner_));
+ channel_server_ = IPC::ChannelProxy::Create(
+ IPC::ChannelHandle(pipe), IPC::Channel::MODE_CLIENT, this, task_runner_);
HANDLE temp_handle;
ASSERT_TRUE(DuplicateHandle(GetCurrentProcess(),

Powered by Google App Engine
This is Rietveld 408576698