Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 310833003: Make BootstrapSandboxPolicy a struct, containing the existing rule map and a new default rule. (Closed)

Created:
6 years, 6 months ago by Robert Sesek
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Make BootstrapSandboxPolicy a struct, containing the existing rule map and a new default rule. The default rule will be used to specify the action to take when the requested name does not have an entry in the rule map. BUG=367863 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274676

Patch Set 1 #

Total comments: 2

Patch Set 2 : const auto& #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -37 lines) Patch
M sandbox/mac/bootstrap_sandbox_unittest.mm View 6 chunks +80 lines, -8 lines 0 comments Download
M sandbox/mac/launchd_interception_server.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M sandbox/mac/policy.h View 1 chunk +14 lines, -2 lines 0 comments Download
M sandbox/mac/policy.cc View 1 1 chunk +26 lines, -14 lines 0 comments Download
M sandbox/mac/policy_unittest.cc View 4 chunks +45 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
6 years, 6 months ago (2014-06-03 16:32:06 UTC) #1
Mark Mentovai
LGTM. https://codereview.chromium.org/310833003/diff/1/sandbox/mac/policy.cc File sandbox/mac/policy.cc (right): https://codereview.chromium.org/310833003/diff/1/sandbox/mac/policy.cc#newcode49 sandbox/mac/policy.cc:49: for (BootstrapSandboxPolicy::NamedRules::const_iterator it = You can just write ...
6 years, 6 months ago (2014-06-03 16:57:26 UTC) #2
Robert Sesek
https://codereview.chromium.org/310833003/diff/1/sandbox/mac/policy.cc File sandbox/mac/policy.cc (right): https://codereview.chromium.org/310833003/diff/1/sandbox/mac/policy.cc#newcode49 sandbox/mac/policy.cc:49: for (BootstrapSandboxPolicy::NamedRules::const_iterator it = On 2014/06/03 16:57:27, Mark Mentovai ...
6 years, 6 months ago (2014-06-03 17:30:52 UTC) #3
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 6 months ago (2014-06-03 17:30:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/310833003/20001
6 years, 6 months ago (2014-06-03 17:31:50 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 00:10:28 UTC) #6
Message was sent while issue was closed.
Change committed as 274676

Powered by Google App Engine
This is Rietveld 408576698