Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 31083002: Fix for cropped matrix convolution for BottomLeft render targets. (Closed)

Created:
7 years, 2 months ago by Stephen White
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix for cropped matrix convolution for BottomLeft render targets. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11872

Patch Set 1 #

Patch Set 2 : Tweak for clarity #

Patch Set 3 : matrixconvolution GM: move crop rect up, so it's not symmetric in Y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M gm/matrixconvolution.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen White
Brian: PTAL. Thanks!
7 years, 2 months ago (2013-10-20 16:09:54 UTC) #1
Stephen White
Since this fixes a nasty regression in Chrome, I'm going to go ahead and land ...
7 years, 2 months ago (2013-10-20 20:20:57 UTC) #2
Stephen White
Committed patchset #3 manually as r11872 (presubmit successful).
7 years, 2 months ago (2013-10-20 20:21:24 UTC) #3
bsalomon
7 years, 2 months ago (2013-10-21 13:20:00 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698