Issue 310803003: Update DecodeFieldToSmi to support x32 port.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 310803003: Update DecodeFieldToSmi to support x32 port. (Closed)

Created:
6 years, 6 months ago by haitao.feng

Modified:
6 years, 6 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update DecodeFieldToSmi to support x32 port. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21738

Patch Set 2 : Fixed the Windows and Mac build error #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	src/x64/macro-assembler-x64.h	View	1	1 chunk	+16 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

Fixed the Mac/Windows build error. https://codereview.chromium.org/310803003/diff/20001/src/x64/macro-assembler-x64.h File src/x64/macro-assembler-x64.h (right): https://codereview.chromium.org/310803003/diff/20001/src/x64/macro-assembler-x64.h#newcode1030 src/x64/macro-assembler-x64.h:1030: static const int mask ...

6 years, 6 months ago (2014-06-09 05:43:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21738.

Expand Messages | Collapse Messages

Issue 310803003: Update DecodeFieldToSmi to support x32 port. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed the Windows and Mac build error #

Messages