Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 310793002: Oilpan: trace HTMLConstructionSite::PendingText part object. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: trace HTMLConstructionSite::PendingText part object. Convert a pair of RefPtr<>s to Members with Oilpan enabled & have the PendingText object be traced by its HTMLConstructionSite parent. Convert remaining RefPtr<Node> uses in html/ as well. R=zerny@chromium.org,ager@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M Source/core/dom/Element.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.h View 3 chunks +9 lines, -5 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-03 11:47:07 UTC) #1
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-03 11:51:53 UTC) #2
Mads Ager (chromium)
lgtm2
6 years, 6 months ago (2014-06-03 11:53:12 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-03 11:56:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/310793002/1
6 years, 6 months ago (2014-06-03 11:57:02 UTC) #5
haraken
LGTM
6 years, 6 months ago (2014-06-03 12:02:08 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-03 13:03:40 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 13:36:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10360)
6 years, 6 months ago (2014-06-03 13:36:29 UTC) #9
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-03 13:38:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/310793002/1
6 years, 6 months ago (2014-06-03 13:38:34 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 14:26:36 UTC) #12
Message was sent while issue was closed.
Change committed as 175369

Powered by Google App Engine
This is Rietveld 408576698