Adding generic callback interfaces.

Adding generic callback interfaces.

Mojo interfaces are asynchronous. This CL adds generic callback
functions that will be used to define vase interface for return parameters to method calls.

R=viettrungluu@chromium.org,rmcilroy@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275423

[rmcilroy, 2014-06-04 10:05:26]

On 2014/06/03 11:58:14, qsr wrote:

This seems pretty ugly IMO to have a separate interface for each call with
different numbers of arguments?  It's difficult for me to suggest alternatives
without some idea of the context though - could you provide some context where
this would be used?  Also, do we really need to check in a script for generating
this one file?  Will it be used to generate other files?

[qsr, 2014-06-04 16:11:14]

As discussed, changed Functions to Callbacks.

 I let you decide if we want to let the generator script in the repo or not.

[rmcilroy, 2014-06-05 12:10:25]

lgtm, with comments.

https://codereview.chromium.org/310783004/diff/40001/mojo/bindings/java/src/o...
File mojo/bindings/java/src/org/chromium/mojo/bindings/Callbacks.java (right):

https://codereview.chromium.org/310783004/diff/40001/mojo/bindings/java/src/o...
mojo/bindings/java/src/org/chromium/mojo/bindings/Callbacks.java:117: public
void call(T1 t1, T2 t2, T3 t3, T4 t4, T5 t5, T6 t6, T7 t7);
nit - t1->arg1, etc.

https://codereview.chromium.org/310783004/diff/40001/mojo/tools/generate_java...
File mojo/tools/generate_java_callback_interfaces.py (right):

https://codereview.chromium.org/310783004/diff/40001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:35: 
nit - remove this newline to avoid a double newline at the bottom of the
generated class.

https://codereview.chromium.org/310783004/diff/40001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:41: ['@param <T%d> the type of
the %d argument.' % (i+1, i+1)
"the type of argument %d."

[qsr, 2014-06-05 12:40:12]

https://codereview.chromium.org/310783004/diff/40001/mojo/tools/generate_java...
File mojo/tools/generate_java_callback_interfaces.py (right):

https://codereview.chromium.org/310783004/diff/40001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:35: 
On 2014/06/05 12:10:26, rmcilroy wrote:
> nit - remove this newline to avoid a double newline at the bottom of the
> generated class.

Done.

https://codereview.chromium.org/310783004/diff/40001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:41: ['@param <T%d> the type of
the %d argument.' % (i+1, i+1)
On 2014/06/05 12:10:26, rmcilroy wrote:
> "the type of argument %d."

Done.

[viettrungluu, 2014-06-06 01:19:41]

LGTM w/English nits.

https://codereview.chromium.org/310783004/diff/60001/mojo/tools/generate_java...
File mojo/tools/generate_java_callback_interfaces.py (right):

https://codereview.chromium.org/310783004/diff/60001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:8: * A generic %d argument(s)
callback.
"... %d-argument callback."

(Add a hyphen, and no 's' even when %d > 1.)

https://codereview.chromium.org/310783004/diff/60001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:25: // This file has been
generated using
"has been" -> "was"

https://codereview.chromium.org/310783004/diff/60001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:31: * Contain generic interface
for callbacks.
"Contains a generic interface for callbacks."

[qsr, 2014-06-06 08:22:06]

Thanks.

https://codereview.chromium.org/310783004/diff/60001/mojo/tools/generate_java...
File mojo/tools/generate_java_callback_interfaces.py (right):

https://codereview.chromium.org/310783004/diff/60001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:8: * A generic %d argument(s)
callback.
On 2014/06/06 01:19:41, viettrungluu wrote:
> "... %d-argument callback."
> 
> (Add a hyphen, and no 's' even when %d > 1.)

Done.

https://codereview.chromium.org/310783004/diff/60001/mojo/tools/generate_java...
mojo/tools/generate_java_callback_interfaces.py:25: // This file has been
generated using
On 2014/06/06 01:19:41, viettrungluu wrote:
> "has been" -> "was"

Done.

[qsr, 2014-06-06 08:22:29]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-06-06 08:24:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/310783004/80001

[commit-bot: I haz the power, 2014-06-06 13:22:42]

Change committed as 275423