Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h

Issue 310783002: test_runner: Migrate MockWebRTCDTMFSenderHandler to Chromium C++ style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h
diff --git a/content/shell/renderer/test_runner/MockWebRTCDTMFSenderHandler.h b/content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h
similarity index 50%
rename from content/shell/renderer/test_runner/MockWebRTCDTMFSenderHandler.h
rename to content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h
index d475cb4965db44bfc6026e9c19295b6894fa3902..60ff6a4f77ea8f575c93a9205c0195b662682fa3 100644
--- a/content/shell/renderer/test_runner/MockWebRTCDTMFSenderHandler.h
+++ b/content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h
@@ -17,30 +17,33 @@ namespace content {
class WebTestDelegate;
class MockWebRTCDTMFSenderHandler : public blink::WebRTCDTMFSenderHandler {
-public:
- MockWebRTCDTMFSenderHandler(const blink::WebMediaStreamTrack&, WebTestDelegate*);
+ public:
+ MockWebRTCDTMFSenderHandler(const blink::WebMediaStreamTrack&,
jochen (gone - plz use gerrit) 2014/06/03 12:55:00 nit. add parameter names
Nikhil 2014/06/04 05:33:55 Done.
+ WebTestDelegate*);
- virtual void setClient(blink::WebRTCDTMFSenderHandlerClient*) OVERRIDE;
+ virtual void setClient(blink::WebRTCDTMFSenderHandlerClient*) OVERRIDE;
jochen (gone - plz use gerrit) 2014/06/03 12:55:00 nit. add a comment saying which interface you're o
Nikhil 2014/06/04 05:33:55 Done.
- virtual blink::WebString currentToneBuffer() OVERRIDE;
+ virtual blink::WebString currentToneBuffer() OVERRIDE;
- virtual bool canInsertDTMF() OVERRIDE;
- virtual bool insertDTMF(const blink::WebString& tones, long duration, long interToneGap) OVERRIDE;
+ virtual bool canInsertDTMF() OVERRIDE;
+ virtual bool insertDTMF(const blink::WebString& tones,
+ long duration,
+ long inter_tone_gap) OVERRIDE;
- // WebTask related methods
- WebTaskList* mutable_task_list() { return &m_taskList; }
- void clearToneBuffer() { m_toneBuffer.reset(); }
+ // WebTask related methods
+ WebTaskList* mutable_task_list() { return &task_list_; }
+ void ClearToneBuffer() { tone_buffer_.reset(); }
-private:
- MockWebRTCDTMFSenderHandler();
+ private:
+ MockWebRTCDTMFSenderHandler();
- blink::WebRTCDTMFSenderHandlerClient* m_client;
- blink::WebMediaStreamTrack m_track;
- blink::WebString m_toneBuffer;
- WebTaskList m_taskList;
- WebTestDelegate* m_delegate;
+ blink::WebRTCDTMFSenderHandlerClient* client_;
+ blink::WebMediaStreamTrack track_;
+ blink::WebString tone_buffer_;
+ WebTaskList task_list_;
+ WebTestDelegate* delegate_;
- DISALLOW_COPY_AND_ASSIGN(MockWebRTCDTMFSenderHandler);
+ DISALLOW_COPY_AND_ASSIGN(MockWebRTCDTMFSenderHandler);
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698