Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 310783002: test_runner: Migrate MockWebRTCDTMFSenderHandler to Chromium C++ style (Closed)

Created:
6 years, 6 months ago by Nikhil
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

test_runner: Migrate MockWebRTCDTMFSenderHandler to Chromium C++ style Changes: 1) Run clang-format through source and header files. 2) Fix member variables names. 3) Rename file name to mock_webrtc_dtmf_sender_handler. BUG=360000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274805

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -124 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebRTCDTMFSenderHandler.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebRTCDTMFSenderHandler.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCPeerConnectionHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
A content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc View 1 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikhil
PTAL. Thanks! If you've any review comments, then please let me know. I'll incorporate them.
6 years, 6 months ago (2014-06-03 09:22:15 UTC) #1
jochen (gone - plz use gerrit)
lgtm with nits https://codereview.chromium.org/310783002/diff/1/content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc File content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc (right): https://codereview.chromium.org/310783002/diff/1/content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc#newcode51 content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc:51: assert(client_ && !track_.isNull()); DCHECK https://codereview.chromium.org/310783002/diff/1/content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h File ...
6 years, 6 months ago (2014-06-03 12:55:00 UTC) #2
Nikhil
Review comments incorporated. PTAL. Thanks! https://codereview.chromium.org/310783002/diff/1/content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc File content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc (right): https://codereview.chromium.org/310783002/diff/1/content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc#newcode51 content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc:51: assert(client_ && !track_.isNull()); On ...
6 years, 6 months ago (2014-06-04 05:33:55 UTC) #3
jochen (gone - plz use gerrit)
still lgtm
6 years, 6 months ago (2014-06-04 07:31:23 UTC) #4
Nikhil
The CQ bit was checked by n.bansal@samsung.com
6 years, 6 months ago (2014-06-04 07:57:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/n.bansal@samsung.com/310783002/20001
6 years, 6 months ago (2014-06-04 07:58:42 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 13:29:17 UTC) #7
Message was sent while issue was closed. 
Change committed as 274805

Powered by Google App Engine
This is Rietveld 408576698