When flag --nouse-osr is set, don't allow osr from hidden runtime calls.

When flag --nouse-osr is set, don't allow osr from hidden runtime calls.

BUG=379770
R=yangguo@chromium.org
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=21622

[mvstanton, 2014-06-03 05:51:18]

Hi Yang,
Here is a small OSR issue. PTAL, thx!
--Michael

[Yang, 2014-06-03 07:10:13]

LGTM, but the test case can be a *lot* simpler. Something like

Flags: --nouse-osr
function f() {
  %OptimizeFunctionOnNextCall(f, "osr");
  for (var i = 0; i < 1000; i++);
}
f();

https://codereview.chromium.org/310773003/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/310773003/diff/1/src/runtime.cc#newcode8718
src/runtime.cc:8718: ASSERT(FLAG_use_osr);
RUNTIME_ASSERT is more appropriate.

[mvstanton, 2014-06-03 07:43:51]

Thanks, I simplified the test and added the runtime assert. Much appreciated!
--Michael

[mvstanton, 2014-06-03 07:45:47]

Committed patchset #2 manually as r21622 (presubmit successful).