Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 310753002: Add ability to set the border insets of a box layout. (Closed)

Created:
6 years, 6 months ago by calamity
Modified:
6 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, tapted
Visibility:
Public.

Description

Add ability to set the border insets of a box layout. This CL makes it possible to give a border insets to box layout which overrides the constructor settings for border spacing. This lets the client have more control on the insets of its child views. This is a precursor to https://codereview.chromium.org/307333002/. BUG=349727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M ui/views/layout/box_layout.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/layout/box_layout_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
calamity
+sadrul for ui/views OWNERS.
6 years, 6 months ago (2014-06-04 05:15:01 UTC) #1
sadrul
lgtm
6 years, 6 months ago (2014-06-04 22:39:20 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 6 months ago (2014-06-05 01:19:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/310753002/1
6 years, 6 months ago (2014-06-05 01:21:15 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 06:09:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 06:15:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10861)
6 years, 6 months ago (2014-06-05 06:15:09 UTC) #7
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 6 months ago (2014-06-06 01:14:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/310753002/1
6 years, 6 months ago (2014-06-06 01:16:25 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 01:39:38 UTC) #10
Message was sent while issue was closed.
Change committed as 275295

Powered by Google App Engine
This is Rietveld 408576698