MSE: Start removing Blink-side support for LegacyFrameProcessor

public/platform/WebMediaSource.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 40 matching lines @@
         EndOfStreamStatusNetworkError,
         EndOfStreamStatusDecodeError,
     };
 
     enum FrameProcessorChoice {
         UseLegacyFrameProcessor,
         UseNewFrameProcessor
     };
 
     virtual ~WebMediaSource() { }
-    virtual AddStatus addSourceBuffer(const WebString& type, const WebVector<WebString>& codecs, const FrameProcessorChoice, WebSourceBuffer**) = 0;
+

[acolwell GONE FROM CHROMIUM, 2014/06/13 18:30:40]

nit: Remove unnecessary whitespace on this line?

[wolenetz, 2014/06/16 20:00:24]

Done.

+    // FIXME: Remove addSourceBuffer() that has FrameProcessorChoice, and remove
+    // the default implementations for addSourceBuffer() once Chromium
+    // implementation of the addSourceBuffer() with no FrameProcessorChoice has
+    // landed. See http://crbug.com/249422.
+    virtual AddStatus addSourceBuffer(const WebString& type, const WebVector<WebString>& codecs, const FrameProcessorChoice, WebSourceBuffer** webSourceBuffer)
+    {
+        // Ignore FrameProcessorChoice.
+        return addSourceBuffer(type, codecs, webSourceBuffer);

[acolwell GONE FROM CHROMIUM, 2014/06/13 18:30:40]

I'm assuming you are doing this so you don't have to wait for a DEPS roll to
land https://codereview.chromium.org/315483002/ right?

[wolenetz, 2014/06/16 20:00:24]

That Chromium CL still needs this to land first and be rolled in Blink DEPS.
Otherwise, I would need both implementations added in the first Chromium CL and
a later Chromium cleanup CL. Overall, I chose the sequence of
Blink->roll->Chromium->Blink CLs because the FrameProcessorChoice enum is
defined in Blink and will be needed until Chromium no longer uses it. Once the
Chromium CL is landed, this default implementation of the soon-to-be obsolete
method signature will be required to be able to construct a concrete Chromium
WMSI.

Did I miss a better way of doing this or misunderstand your question?

+    }
+    virtual AddStatus addSourceBuffer(const WebString& type, const WebVector<WebString>& codecs, WebSourceBuffer** webSourceBuffer)
+    {
+        return addSourceBuffer(type, codecs, WebMediaSource::UseNewFrameProcessor, webSourceBuffer);
+    }
+
     virtual double duration() = 0;
     virtual void setDuration(double) = 0;
     virtual void markEndOfStream(EndOfStreamStatus) = 0;
     virtual void unmarkEndOfStream() = 0;
 };
 
 } // namespace blink
 
 #endif