Have Frame::loader() return a reference

Source/web/tests/ProgrammaticScrollTest.cpp

 #include "config.h"
 
 #include <gtest/gtest.h>
 #include "FrameTestHelpers.h"
 #include "URLTestHelpers.h"
 #include "WebFrame.h"
 #include "WebFrameClient.h"
 #include "WebFrameImpl.h"
 #include "WebHistoryItem.h"
 #include "WebInputEvent.h"
@@ skipping 41 matching lines @@
 {
     registerMockedHttpURLLoad("long_scroll.html");
 
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "long_scroll.html", true, 0, 0);
     webView->resize(WebSize(1000, 1000));
     webView->layout();
 
     WebViewImpl* webViewImpl = toWebViewImpl(webView);
     FrameView* frameView = webViewImpl->mainFrameImpl()->frameView();
-    HistoryController* history = webViewImpl->page()->mainFrame()->loader()->history();
+    HistoryController* history = webViewImpl->page()->mainFrame()->loader().history();
 
     // Scale and scroll the page and save that state. Then scale and scroll again and restore.
     webViewImpl->setPageScaleFactor(2.0f, WebPoint(0, 200));
     history->saveDocumentAndScrollState();
     webViewImpl->setPageScaleFactor(3.0f, WebPoint(0, 300));
     // Flip back the wasScrolledByUser flag which was set to true by setPageScaleFactor
     // because otherwise HistoryController::restoreScrollPositionAndViewState does nothing.
     frameView->setWasScrolledByUser(false);
     history->restoreScrollPositionAndViewState();
 
     // Expect that both scroll and scale were restored, and that it was not a programmatic scroll.
     EXPECT_EQ(2.0f, webViewImpl->pageScaleFactor());
     EXPECT_EQ(200, webViewImpl->mainFrameImpl()->scrollOffset().height);
     EXPECT_TRUE(frameView->wasScrolledByUser());
 }
 
 TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithoutScale)
 {
     registerMockedHttpURLLoad("long_scroll.html");
 
     FrameTestHelpers::WebViewHelper webViewHelper;
     WebView* webView = webViewHelper.initializeAndLoad(m_baseURL + "long_scroll.html", true, 0, 0);
     webView->resize(WebSize(1000, 1000));
     webView->layout();
 
     WebViewImpl* webViewImpl = toWebViewImpl(webView);
     FrameView* frameView = webViewImpl->mainFrameImpl()->frameView();
-    HistoryController* history = webViewImpl->page()->mainFrame()->loader()->history();
+    HistoryController* history = webViewImpl->page()->mainFrame()->loader().history();
 
     // Scale and scroll the page and save that state, but then set scale to zero. Then scale and
     // scroll again and restore.
     webViewImpl->setPageScaleFactor(2.0f, WebPoint(0, 400));
     history->saveDocumentAndScrollState();
     webViewImpl->setPageScaleFactor(3.0f, WebPoint(0, 500));
     // Flip back the wasScrolledByUser flag which was set to true by setPageScaleFactor
     // because otherwise HistoryController::restoreScrollPositionAndViewState does nothing.
     frameView->setWasScrolledByUser(false);
     // HistoryController::restoreScrollPositionAndViewState flows differently if scale is zero.
     history->currentItem()->setPageScaleFactor(0.0f);
     history->restoreScrollPositionAndViewState();
 
     // Expect that only the scroll position was restored, and that it was not a programmatic scroll.
     EXPECT_EQ(3.0f, webViewImpl->pageScaleFactor());
     EXPECT_EQ(400, webViewImpl->mainFrameImpl()->scrollOffset().height);
     EXPECT_TRUE(frameView->wasScrolledByUser());
 }
 
 }