Making use of bindless variants mailbox produce/consume.

Making use of bindless variants mailbox produce/consume.

Blink side of https://codereview.chromium.org/299043003/

BUG=354697
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176042

[bajones, 2014-06-10 17:24:15]

Converted DrawingBuffer and ImageBuffer texture copy to use new "bindless"
produce/consume mailbox variants, which can reduce the time spent by ~20% on
some systems.

[bajones, 2014-06-11 18:57:37]

Review ping?

[Ken Russell (switch to Gerrit), 2014-06-11 19:07:03]

Sorry for the delay. Very nice. LGTM

[jamesr, 2014-06-11 19:22:48]

public/ lgtm

[bajones, 2014-06-11 20:13:18]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2014-06-11 20:13:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bajones@chromium.org/310623004/1

[commit-bot: I haz the power, 2014-06-11 21:20:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11610)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15602)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18740)

[commit-bot: I haz the power, 2014-06-11 21:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:21:25]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15654)

[bajones, 2014-06-12 16:11:23]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2014-06-12 16:12:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bajones@chromium.org/310623004/1

[commit-bot: I haz the power, 2014-06-12 16:12:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 16:12:24]

Failed to apply patch for Source/platform/graphics/gpu/DrawingBuffer.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/graphics/gpu/DrawingBuffer.cpp
  Hunk #1 FAILED at 429.
  Hunk #2 succeeded at 464 (offset 26 lines).
  Hunk #3 succeeded at 482 (offset 26 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/platform/graphics/gpu/DrawingBuffer.cpp.rej

Patch:       Source/platform/graphics/gpu/DrawingBuffer.cpp
Index: Source/platform/graphics/gpu/DrawingBuffer.cpp
diff --git a/Source/platform/graphics/gpu/DrawingBuffer.cpp
b/Source/platform/graphics/gpu/DrawingBuffer.cpp
index
d0d58ca3031a8200e51e76541b9972dc86f5e376..1f0846421592b799d8099337d250856db8426937
100644
--- a/Source/platform/graphics/gpu/DrawingBuffer.cpp
+++ b/Source/platform/graphics/gpu/DrawingBuffer.cpp
@@ -429,8 +429,7 @@ bool
DrawingBuffer::copyToPlatformTexture(blink::WebGraphicsContext3D* context,
     // Contexts may be in a different share group. We must transfer the texture
through a mailbox first
     RefPtr<MailboxInfo> bufferMailbox = adoptRef(new MailboxInfo());
     m_context->genMailboxCHROMIUM(bufferMailbox->mailbox.name);
-    m_context->bindTexture(GL_TEXTURE_2D, m_colorBuffer.textureId);
-    m_context->produceTextureCHROMIUM(GL_TEXTURE_2D,
bufferMailbox->mailbox.name);
+    m_context->produceTextureDirectCHROMIUM(m_colorBuffer.textureId,
GL_TEXTURE_2D, bufferMailbox->mailbox.name);
     m_context->flush();
 
     bufferMailbox->mailbox.syncPoint = m_context->insertSyncPoint();
@@ -438,16 +437,8 @@ bool
DrawingBuffer::copyToPlatformTexture(blink::WebGraphicsContext3D* context,
     if (!context->makeContextCurrent())
         return false;
 
-    Platform3DObject sourceTexture = context->createTexture();
-
-    // TODO(bajones): Should be able to change the texture bindings here
without reverting but
-    // something else in the system is depending on it. Failing to revert
causes WebGL
-    // tests to fail. We should find out why and fix it.
-    GLint boundTexture = 0;
-    context->getIntegerv(GL_TEXTURE_BINDING_2D, &boundTexture);
-    context->bindTexture(GL_TEXTURE_2D, sourceTexture);
     context->waitSyncPoint(bufferMailbox->mailbox.syncPoint);
-    context->consumeTextureCHROMIUM(GL_TEXTURE_2D,
bufferMailbox->mailbox.name);
+    Platform3DObject sourceTexture =
context->createAndConsumeTextureCHROMIUM(GL_TEXTURE_2D,
bufferMailbox->mailbox.name);
 
     bool unpackPremultiplyAlphaNeeded = false;
     bool unpackUnpremultiplyAlphaNeeded = false;
@@ -464,7 +455,6 @@ bool
DrawingBuffer::copyToPlatformTexture(blink::WebGraphicsContext3D* context,
     context->pixelStorei(GC3D_UNPACK_UNPREMULTIPLY_ALPHA_CHROMIUM, false);
     context->pixelStorei(GC3D_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM, false);
 
-    context->bindTexture(GL_TEXTURE_2D, boundTexture);
     context->deleteTexture(sourceTexture);
 
     context->flush();

[bajones, 2014-06-12 17:06:16]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2014-06-12 17:06:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bajones@chromium.org/310623004/10001

[commit-bot: I haz the power, 2014-06-12 18:18:56]

Change committed as 176042