Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 310613002: Enable drive: protocol in incognito windows. (Closed)

Created:
6 years, 6 months ago by kinaba
Modified:
6 years, 6 months ago
Reviewers:
hashimoto, mmenke
CC:
chromium-reviews
Visibility:
Public.

Description

Enable drive: protocol in incognito windows. This is a part of effort for enabling Drive in open file dialog of incognito windows. It enabled protocol handler for drive: scheme in incognito profiles. BUG=359418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kinaba
PTAL. @hashimoto: from Drive implementation perspective. @mmenke: as a ProfileIOData OWNER. (The feature is still ...
6 years, 6 months ago (2014-06-04 23:10:05 UTC) #1
mmenke
On 2014/06/04 23:10:05, kinaba wrote: > PTAL. > @hashimoto: from Drive implementation perspective. > @mmenke: ...
6 years, 6 months ago (2014-06-05 00:46:57 UTC) #2
hashimoto
lgtm. The only concern here is that this feature may leave the file being read ...
6 years, 6 months ago (2014-06-05 03:25:23 UTC) #3
hashimoto
On 2014/06/05 03:25:23, hashimoto wrote: > lgtm. > The only concern here is that this ...
6 years, 6 months ago (2014-06-05 03:25:51 UTC) #4
kinaba
On 2014/06/05 03:25:51, hashimoto wrote: > On 2014/06/05 03:25:23, hashimoto wrote: > > lgtm. > ...
6 years, 6 months ago (2014-06-06 13:11:43 UTC) #5
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-06 13:11:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/310613002/1
6 years, 6 months ago (2014-06-06 13:12:00 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 14:09:26 UTC) #8
Message was sent while issue was closed.
Change committed as 275435

Powered by Google App Engine
This is Rietveld 408576698