Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1809)

Unified Diff: Source/modules/modules.gyp

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak (reupload) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/modules.gyp
diff --git a/Source/modules/modules.gyp b/Source/modules/modules.gyp
index 9b09014759442367d2bf75a2808f156034df9f51..85857c9acbd0392dae49d58df583f6153eca66e3 100644
--- a/Source/modules/modules.gyp
+++ b/Source/modules/modules.gyp
@@ -56,6 +56,7 @@
'msvs_disabled_warnings': [ 4267, 4334, ]
},
{
+ # FIXME: should be in modules_generated.gyp
'target_name': 'modules_bindings_generated',
'type': 'none',
'actions': [
@@ -75,7 +76,9 @@
'<@(event_idl_files)',
],
'outputs': [
- '<(blink_output_dir)/EventModulesInterfaces.in',
+ # FIXME: should output to blink_modules_output_dir
+ # http://crbug.com/358074
+ '<(SHARED_INTERMEDIATE_DIR)/blink/EventModulesInterfaces.in',
],
'action': [
'python',
@@ -83,7 +86,7 @@
'--event-idl-files-list',
'<(event_idl_files_list)',
'--event-interfaces-file',
- '<(blink_output_dir)/EventModulesInterfaces.in',
+ '<(SHARED_INTERMEDIATE_DIR)/blink/EventModulesInterfaces.in',
'--write-file-only-if-changed',
'<(write_file_only_if_changed)',
'--suffix',
@@ -109,6 +112,7 @@
},
{
+ # FIXME: should be in modules_generated.gyp
'target_name': 'make_modules_generated',
'type': 'none',
'hard_dependency': 1,

Powered by Google App Engine
This is Rietveld 408576698