Source/bindings/modules/modules.gypi - Issue 310563004: IDL build: Split global constructors into core and modules

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/modules/modules.gypi

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Better includes and FIXMEs in core.gyp Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'includes': [	6 'includes': [

7 '../bindings.gypi', # FIXME: factor out bindings_modules http://crbug.com/3 58074	7 '../bindings.gypi',
	haraken 2014/06/03 15:31:10 FIXME: remove this? FIXME: remove this? Nils Barth (inactive) 2014/06/04 03:36:31 ditto (going away immediately) Show quoted text On 2014/06/03 15:31:10, haraken wrote: > FIXME: remove this? ditto (going away immediately)
8 'v8/generated.gypi',	8 'v8/generated.gypi',
	haraken 2014/06/03 15:31:10 Doesn't this GYP also depend on: ../v8/v8.gypi # Doesn't this GYP also depend on: ../v8/v8.gypi # FIXME: this should be v8/v8.gypi ../../core/generated.gypi ? Nils Barth (inactive) 2014/06/04 03:36:31 No: Source/modules doesn't use these. (They're onl Show quoted text On 2014/06/03 15:31:10, haraken wrote: > Doesn't this GYP also depend on: > > ../v8/v8.gypi # FIXME: this should be v8/v8.gypi > ../../core/generated.gypi > > ? No: Source/modules doesn't use these. (They're only in bindings/core/core.gypi b/c Source/core uses them directly.)
9 ],	9 ],

10	10

11 'variables': {	11 'variables': {

12 'bindings_modules_output_dir': '<(bindings_output_dir)/modules',	12 'bindings_modules_output_dir': '<(bindings_output_dir)/modules',

13 },	13 },

14 }	14 }

OLD	NEW

« Source/bindings/modules/idl.gypi ('K') | « Source/bindings/modules/idl.gypi ('k') | Source/bindings/modules/v8/generated.gyp » ('j') | Source/bindings/modules/v8/generated.gyp » ('J')