IDL build: Split global constructors into core and modules

Source/bindings/modules/generated.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Generate IDL interfaces info for modules, used to generate bindings
 #
 # Design doc: http://www.chromium.org/developers/design-documents/idl-build
 
 {
   'includes': [
+    '../../modules/modules.gypi',
     '../bindings.gypi',
     '../core/core.gypi',
+    '../core/generated.gypi',
     '../scripts/scripts.gypi',
     'idl.gypi',
     'modules.gypi',

[haraken, 2014/06/02 15:45:14]

Why doesn't this depend on 'generated.gypi' ?

[Nils Barth (inactive), 2014/06/03 01:47:50]

Good catch!
Because the modules generated files are generated in bindings_core
(since they are used by core bindings).
I've added a FIXME.

   ],
 
   'targets': [
 ################################################################################
   {
     'target_name': 'interfaces_info_individual_modules',
     'type': 'none',
     'dependencies': [
-      # FIXME: should be modules_generated_idls
-      # http://crbug.com/358074
-      '../generated.gyp:generated_idls',
+      # FIXME: should be defined in this file
+      '../core/generated.gyp:modules_global_constructors_idls',
     ],
     'actions': [{
       'action_name': 'compute_interfaces_info_individual_modules',
       'inputs': [
         '<(bindings_scripts_dir)/compute_interfaces_info_individual.py',
         '<(bindings_scripts_dir)/utilities.py',
         '<(modules_static_idl_files_list)',
         '<@(modules_static_idl_files)',
-        # No generated files currently, will add with constructors
-        # '<@(modules_generated_idl_files)',
+        '<@(modules_generated_idl_files)',
       ],
       'outputs': [
         '<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
       ],
       'action': [
         'python',
         '<(bindings_scripts_dir)/compute_interfaces_info_individual.py',
         '--component-dir',
         'modules',
         '--idl-files-list',
         '<(modules_static_idl_files_list)',
         '--interfaces-info-file',
         '<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
         '--write-file-only-if-changed',
         '<(write_file_only_if_changed)',
-        # No generated files currently, will add with constructors
-        # '--',
+        '--',
         # Generated files must be passed at command line
-        # '<@(modules_generated_idl_files)',
+        '<@(modules_generated_idl_files)',
       ],
       'message': 'Computing global information about individual IDL files',
       }]
   },
 ################################################################################
   {
     'target_name': 'interfaces_info',
     'type': 'none',
     'dependencies': [
         '../core/generated.gyp:interfaces_info_individual_core',
@@ skipping 18 matching lines @@
         '<(bindings_core_output_dir)/InterfacesInfoCoreIndividual.pickle',
         '<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
         '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
       ],
       'message': 'Computing overall global information about IDL files',
       }]
   },
 ################################################################################
   ],  # targets
 }