Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: trunk/src/net/http/http_stream_factory_impl_request.cc

Issue 310563002: Revert 273680 "Defer SpdySession destruction to support closing ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/net/http/http_stream_factory_impl_request.cc
===================================================================
--- trunk/src/net/http/http_stream_factory_impl_request.cc (revision 274100)
+++ trunk/src/net/http/http_stream_factory_impl_request.cc (working copy)
@@ -250,13 +250,6 @@
}
}
-// TODO(jgraettinger): Currently, HttpStreamFactoryImpl::Job notifies a
-// Request that the session is ready, which in turn notifies it's delegate,
-// and then it notifies HttpStreamFactoryImpl so that /other/ requests may
-// be woken, but only if the spdy_session is still okay. This is tough to grok.
-// Instead, see if Job can notify HttpStreamFactoryImpl only, and have one
-// path for notifying any requests waiting for the session (including the
-// request which spawned it).
void HttpStreamFactoryImpl::Request::OnNewSpdySessionReady(
Job* job,
scoped_ptr<HttpStream> stream,
@@ -299,7 +292,7 @@
stream.release());
}
// |this| may be deleted after this point.
- if (spdy_session && spdy_session->IsAvailable()) {
+ if (spdy_session) {
factory->OnNewSpdySessionReady(spdy_session,
direct,
used_ssl_config,
« no previous file with comments | « trunk/src/net/http/http_stream_factory_impl_job.cc ('k') | trunk/src/net/spdy/spdy_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698