Adds support for showing the match preview on views. It's behind the

Adds support for showing the match preview on views. It's behind the
flag --enable-match-preview. There is still a lot of details to get it
working good enough, but this is a good point to check some stuff in.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55665

[sky, 2010-08-10 20:45:51]

Jay,

I'm sending this your way as Ben is in meetings all day.
Thanks,

  -Scott

[Jay Civelli, 2010-08-10 21:26:17]

http://codereview.chromium.org/3105004/diff/4001/5003
File chrome/browser/tab_contents/match_preview.cc (right):

http://codereview.chromium.org/3105004/diff/4001/5003#newcode22
chrome/browser/tab_contents/match_preview.cc:22:
TabContentsDelegateImpl(MatchPreview* match_preview)
Should be explicit.

http://codereview.chromium.org/3105004/diff/4001/5003#newcode137
chrome/browser/tab_contents/match_preview.cc:137: preview_contents_.reset(NULL);
Isn't the TabContents deleted before the delegate anyway since its declaration
in the class appears after the delegate's one?

http://codereview.chromium.org/3105004/diff/4001/5004
File chrome/browser/tab_contents/match_preview.h (right):

http://codereview.chromium.org/3105004/diff/4001/5004#newcode39
chrome/browser/tab_contents/match_preview.h:39: // is non-empty and the preview
Tabcontents has not been created it is
Nit: Tabcontents -> TabContents

http://codereview.chromium.org/3105004/diff/4001/5009
File chrome/browser/tabs/tab_strip_model.cc (right):

http://codereview.chromium.org/3105004/diff/4001/5009#newcode1060
chrome/browser/tabs/tab_strip_model.cc:1060: // MakePhantom is called when the
TabContents is being destoryed so we don't
Typo: destroyed

http://codereview.chromium.org/3105004/diff/4001/5011
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/3105004/diff/4001/5011#newcode160
chrome/browser/views/frame/browser_view.cc:160: RemoveChildView(preview_);
Who is deleting the removed preview_?

[sky, 2010-08-10 22:07:12]

New snapshot uploaded.

  -Scott

http://codereview.chromium.org/3105004/diff/4001/5003
File chrome/browser/tab_contents/match_preview.cc (right):

http://codereview.chromium.org/3105004/diff/4001/5003#newcode137
chrome/browser/tab_contents/match_preview.cc:137: preview_contents_.reset(NULL);
On 2010/08/10 21:26:17, Jay Civelli wrote:
> Isn't the TabContents deleted before the delegate anyway since its declaration
> in the class appears after the delegate's one?

Yes, but I wanted to make it explicit so folks know it has to be this way.

http://codereview.chromium.org/3105004/diff/4001/5011
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/3105004/diff/4001/5011#newcode160
chrome/browser/views/frame/browser_view.cc:160: RemoveChildView(preview_);
On 2010/08/10 21:26:17, Jay Civelli wrote:
> Who is deleting the removed preview_?

Line 2348. I'll add a comment that this doesn't delete the old.

[Jay Civelli, 2010-08-10 22:10:12]

LGTM