metrics: call LoginState::Shutdown() at end of unit tests

metrics: call LoginState::Shutdown() at end of unit tests

These need to balance out the calls to LoginState::Initialize().

BUG=chromium:379140
TEST=unit tests pass

Signed-off-by: Simon Que <sque@chromium.org>;

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274109

[Alexei Svitkine (slow), 2014-05-30 18:57:03]

lgtm

[blundell, 2014-05-30 19:10:37]

I think you're missing at least one in ChromeOSMetricsProviderTest.

[Simon Que, 2014-05-30 20:51:01]

The CQ bit was checked by sque@chromium.org

[commit-bot: I haz the power, 2014-05-30 20:55:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sque@chromium.org/310493002/1

[Simon Que, 2014-05-30 20:59:52]

On 2014/05/30 19:10:37, blundell wrote:
> I think you're missing at least one in ChromeOSMetricsProviderTest.

Could you please elaborate? I am not sure what the dependency is in
ChromeOSMetricsProviderTest.

[blundell, 2014-05-30 21:20:34]

See
https://codereview.chromium.org/301633006/diff/180001/chrome/browser/metrics/...

[Simon Que, 2014-05-30 21:22:22]

On 2014/05/30 21:20:34, blundell wrote:
> See
>
https://codereview.chromium.org/301633006/diff/180001/chrome/browser/metrics/...

Ah I see, the code search on crbug.com hadn't picked up that change yet.

[commit-bot: I haz the power, 2014-05-31 01:31:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-31 02:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 02:06:05]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[Simon Que, 2014-05-31 03:19:19]

The CQ bit was checked by sque@chromium.org

[commit-bot: I haz the power, 2014-05-31 03:22:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sque@chromium.org/310493002/20001

[commit-bot: I haz the power, 2014-05-31 06:31:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-31 08:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 08:21:55]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Simon Que, 2014-06-01 01:59:57]

The CQ bit was checked by sque@chromium.org

[commit-bot: I haz the power, 2014-06-01 02:00:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sque@chromium.org/310493002/20001

[commit-bot: I haz the power, 2014-06-01 12:16:24]

Change committed as 274109