Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 310483010: Fall back to using clip effect for outer rrect in drawdrrect (Closed)

Created:
6 years, 6 months ago by bsalomon
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fall back to using clip effect for outer rect in drawdrrect Committed: https://skia.googlesource.com/skia/+/8af0523b38f25993c8b1ba3a3562b9f9ac87162d

Patch Set 1 #

Patch Set 2 : add test to ignored-tests.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
6 years, 6 months ago (2014-06-02 21:38:16 UTC) #1
jvanverth1
lgtm
6 years, 6 months ago (2014-06-03 13:13:57 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 6 months ago (2014-06-03 13:22:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/310483010/20001
6 years, 6 months ago (2014-06-03 13:22:59 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 13:35:03 UTC) #5
Message was sent while issue was closed.
Change committed as 8af0523b38f25993c8b1ba3a3562b9f9ac87162d

Powered by Google App Engine
This is Rietveld 408576698