Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: components/metrics/metrics_log_manager.cc

Issue 310483009: Remove NO_LOG LogType enum value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_log_base.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log_manager.cc
===================================================================
--- components/metrics/metrics_log_manager.cc (revision 274238)
+++ components/metrics/metrics_log_manager.cc (working copy)
@@ -102,12 +102,13 @@
}
void MetricsLogManager::StoreLog(std::string* log, LogType log_type) {
- DCHECK_NE(MetricsLogBase::NO_LOG, log_type);
- metrics::PersistedLogs* destination_queue =
- (log_type == MetricsLogBase::INITIAL_STABILITY_LOG) ?
- &initial_log_queue_ : &ongoing_log_queue_;
-
- destination_queue->StoreLog(log);
+ switch (log_type) {
+ case MetricsLogBase::INITIAL_STABILITY_LOG:
+ initial_log_queue_.StoreLog(log);
+ break;
+ case MetricsLogBase::ONGOING_LOG:
+ ongoing_log_queue_.StoreLog(log);
Ilya Sherman 2014/06/02 22:06:19 nit: Probably wise to have a "break;" stmt here as
Alexei Svitkine (slow) 2014/06/03 16:52:53 Done.
+ }
}
void MetricsLogManager::StoreStagedLogAsUnsent(
« no previous file with comments | « components/metrics/metrics_log_base.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698