Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 310483009: Remove NO_LOG LogType enum value. (Closed)

Created:
6 years, 6 months ago by Alexei Svitkine (slow)
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Visibility:
Public.

Description

Remove NO_LOG LogType enum value. Also, changes a condition to a switch to make compiler warn if a new enum value is added. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274582

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M components/metrics/metrics_log_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/metrics/metrics_log_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/metrics_log_manager.cc View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
6 years, 6 months ago (2014-06-02 16:49:58 UTC) #1
Ilya Sherman
LGTM % nit. Thanks! https://codereview.chromium.org/310483009/diff/20001/components/metrics/metrics_log_manager.cc File components/metrics/metrics_log_manager.cc (right): https://codereview.chromium.org/310483009/diff/20001/components/metrics/metrics_log_manager.cc#newcode110 components/metrics/metrics_log_manager.cc:110: ongoing_log_queue_.StoreLog(log); nit: Probably wise to ...
6 years, 6 months ago (2014-06-02 22:06:19 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/310483009/diff/20001/components/metrics/metrics_log_manager.cc File components/metrics/metrics_log_manager.cc (right): https://codereview.chromium.org/310483009/diff/20001/components/metrics/metrics_log_manager.cc#newcode110 components/metrics/metrics_log_manager.cc:110: ongoing_log_queue_.StoreLog(log); On 2014/06/02 22:06:19, Ilya Sherman wrote: > nit: ...
6 years, 6 months ago (2014-06-03 16:52:53 UTC) #3
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 6 months ago (2014-06-03 16:52:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/310483009/40001
6 years, 6 months ago (2014-06-03 16:53:56 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:05:36 UTC) #6
Message was sent while issue was closed.
Change committed as 274582

Powered by Google App Engine
This is Rietveld 408576698