Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 310483008: Followup to commit 274223 (Closed)

Created:
6 years, 6 months ago by kaliamoorthi
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@Issue_116119_pre
Visibility:
Public.

Description

Followup to commit 274223 Fixes the memory leak in the unit tests BUG=116119 TBR=koz,jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274256

Patch Set 1 #

Patch Set 2 : Moves a variable from heap to stack for avoiding memory leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -31 lines) Patch
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 2 chunks +27 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kaliamoorthi
The CQ bit was checked by kaliamoorthi@chromium.org
6 years, 6 months ago (2014-06-02 15:22:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaliamoorthi@chromium.org/310483008/1
6 years, 6 months ago (2014-06-02 15:23:38 UTC) #2
bartfab (slow)
6 years, 6 months ago (2014-06-02 16:09:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r274256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698