tools/relocation_packer/relocation_packer.gyp - Issue 310483003: Add a host tool to pack R_ARM_RELATIVE relocations in libchrome.<ver>.so.

Side by Side Diff: tools/relocation_packer/relocation_packer.gyp

Issue 310483003: Add a host tool to pack R_ARM_RELATIVE relocations in libchrome.<ver>.so. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/relocation_packer/README.TXT ('K') | « tools/relocation_packer/README.TXT ('k') | tools/relocation_packer/src/relocation_packer_debug.h » ('j') | tools/relocation_packer/src/relocation_packer_debug.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 'target_name': 'pack_relocations',
	rmcilroy 2014/06/02 15:16:35 nit - lib_relocation_packer ? nit - lib_relocation_packer ? simonb (inactive) 2014/06/04 16:40:35 Done. Show quoted text On 2014/06/02 15:16:35, rmcilroy wrote: > nit - lib_relocation_packer ? Done.
	9 'toolsets': ['host'],

	10 'type': 'static_library',

	11 'dependencies': [

	12 '../../third_party/elfutils/elfutils.gyp:libelf',

	13 ],

	14 'include_dirs': [

	15 'src',
	rmcilroy 2014/06/02 15:16:35 Is this needed? Doesn't seem to be required in th Is this needed? Doesn't seem to be required in the unittest target. simonb (inactive) 2014/06/04 16:40:35 Done. Show quoted text On 2014/06/02 15:16:35, rmcilroy wrote: > Is this needed? Doesn't seem to be required in the unittest target. Done.
	16 ],

	17 'sources': [

	18 'src/relocation_packer_debug.cc',

	19 'src/relocation_packer_elf_file.cc',

	20 'src/relocation_packer_leb128.cc',

	21 'src/relocation_packer_packer.cc',

	22 'src/relocation_packer_rle.cc',
	rmcilroy 2014/06/02 15:16:35 optional nit - maybe avoid the "relocation_packer_ optional nit - maybe avoid the "relocation_packer_" prefix on every filename since it's already in a directory called "relocation_packer". Maybe also extend "rle" to "run_length_encoder.cc". simonb (inactive) 2014/06/04 16:40:35 Done. Show quoted text On 2014/06/02 15:16:35, rmcilroy wrote: > optional nit - maybe avoid the "relocation_packer_" prefix on every filename > since it's already in a directory called "relocation_packer". Maybe also extend > "rle" to "run_length_encoder.cc". Done.
	23 ],

	24 },

	25 {

	26 'target_name': 'relocation_packer',

	27 'toolsets': ['host'],

	28 'type': 'executable',

	29 'dependencies': [

	30 '../../third_party/elfutils/elfutils.gyp:libelf',

	31 'pack_relocations',

	32 ],

	33 'include_dirs': [

	34 'src',

	35 ],

	36 'sources': [

	37 'src/relocation_packer_main.cc',

	38 ],

	39 'link_settings': {

	40 'libraries': [

	41 '-lelf',
	rmcilroy 2014/06/02 15:16:35 Do you need this? I though depending on the libel Do you need this? I though depending on the libelf target would do this for you. simonb (inactive) 2014/06/04 16:40:35 Done. Show quoted text On 2014/06/02 15:16:35, rmcilroy wrote: > Do you need this? I though depending on the libelf target would do this for > you. Done.
	42 ],

	43 },

	44 },

	45 {

	46 'target_name': 'relocation_packer_unittests',

	47 'toolsets': ['host'],

	48 'type': 'executable',

	49 'dependencies': [

	50 '../../testing/gtest.gyp:gtest',

	51 'pack_relocations',

	52 ],

	53 'include_dirs': [

	54 '../..',

	55 ],

	56 'sources': [

	57 'src/relocation_packer_elf_file_unittest.cc',

	58 'src/relocation_packer_leb128_unittest.cc',

	59 'src/relocation_packer_packer_unittest.cc',

	60 'src/relocation_packer_rle_unittest.cc',

	61 'src/run_all_unittests.cc',

	62 ],

	63 },

	64 ],

	65 }

OLD	NEW