Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 310463010: Fixes the initialization of focus and activation management. (Closed)

Created:
6 years, 6 months ago by Jun Mukai
Modified:
6 years, 6 months ago
Reviewers:
James Cook, oshima
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fixes the initialization of focus and activation management. - We don't have to use DefaultActivationController because wm::FocusController provides activation controls. - FocusController should be registered as a pre-target handler to change the focus on mouse click. - InitializeInputMethodForTesting seems unnecessary. Text input is working well while no actual input methods are available. BUG=None R=jamescook@chromium.org, oshima@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274596

Patch Set 1 #

Patch Set 2 : git-cl format #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M apps/shell/browser/shell_desktop_controller.cc View 1 5 chunks +13 lines, -8 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
6 years, 6 months ago (2014-06-03 00:32:03 UTC) #1
oshima
lgtm https://codereview.chromium.org/310463010/diff/20001/apps/shell/browser/shell_desktop_controller.cc File apps/shell/browser/shell_desktop_controller.cc (left): https://codereview.chromium.org/310463010/diff/20001/apps/shell/browser/shell_desktop_controller.cc#oldcode235 apps/shell/browser/shell_desktop_controller.cc:235: ui::InitializeInputMethodForTesting(); can you check if app_shell_browsertests passes with ...
6 years, 6 months ago (2014-06-03 00:42:52 UTC) #2
Jun Mukai
https://codereview.chromium.org/310463010/diff/20001/apps/shell/browser/shell_desktop_controller.cc File apps/shell/browser/shell_desktop_controller.cc (left): https://codereview.chromium.org/310463010/diff/20001/apps/shell/browser/shell_desktop_controller.cc#oldcode235 apps/shell/browser/shell_desktop_controller.cc:235: ui::InitializeInputMethodForTesting(); On 2014/06/03 00:42:53, oshima wrote: > can you ...
6 years, 6 months ago (2014-06-03 00:57:45 UTC) #3
James Cook
lgtm
6 years, 6 months ago (2014-06-03 15:54:29 UTC) #4
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-03 17:01:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/310463010/20001
6 years, 6 months ago (2014-06-03 17:02:42 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:50:47 UTC) #7
Message was sent while issue was closed.
Change committed as 274596

Powered by Google App Engine
This is Rietveld 408576698