Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 310463009: LevelDBPrefStore: Initialize uninitialized member in constructor. (Closed)

Created:
6 years, 6 months ago by Finnur
Modified:
6 years, 6 months ago
Reviewers:
dgrogan, battre
CC:
chromium-reviews
Visibility:
Public.

Description

LevelDBPrefStore: Initialize uninitialized member in constructor. BUG=None CID=115981 TBR=battre Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/prefs/leveldb_pref_store.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Finnur
6 years, 6 months ago (2014-06-02 22:22:40 UTC) #1
dgrogan
lgtm
6 years, 6 months ago (2014-06-10 23:36:41 UTC) #2
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 6 months ago (2014-06-11 11:06:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/310463009/1
6 years, 6 months ago (2014-06-11 11:09:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 12:12:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 12:17:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/72975)
6 years, 6 months ago (2014-06-11 12:17:45 UTC) #7
Finnur
Adding Dominic as TBR for OWNERS check.
6 years, 6 months ago (2014-06-11 13:03:08 UTC) #8
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 6 months ago (2014-06-11 13:03:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/310463009/1
6 years, 6 months ago (2014-06-11 13:04:58 UTC) #10
commit-bot: I haz the power
Change committed as 276374
6 years, 6 months ago (2014-06-11 13:11:25 UTC) #11
battre
What does "no_dir" mean?
6 years, 6 months ago (2014-06-11 15:07:09 UTC) #12
Finnur
6 years, 6 months ago (2014-06-11 15:10:30 UTC) #13
Message was sent while issue was closed. 
Not sure. This isn't my code, but it is a bool that is set in
LevelDBPrefStore::DoReading if the path passed in does not exist.

Powered by Google App Engine
This is Rietveld 408576698