Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/autofill/core/browser/contact_info.h

Issue 310463005: Fill in more name fields with requestAutocomplete (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dumb test is dumb Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/contact_info.h
diff --git a/components/autofill/core/browser/contact_info.h b/components/autofill/core/browser/contact_info.h
index 6a37696b87ba87f9e497a2be40a03bdbe849ef04..5478a165e024d681e74674853ba2390234646c92 100644
--- a/components/autofill/core/browser/contact_info.h
+++ b/components/autofill/core/browser/contact_info.h
@@ -37,25 +37,21 @@ class NameInfo : public FormGroup {
virtual void GetSupportedTypes(
ServerFieldTypeSet* supported_types) const OVERRIDE;
- // Returns the full name, which can include up to the first, middle, and last
- // name.
+ // Returns the full name, which is either |full_|, or if |full_| is empty,
+ // is composed of given, middle and family.
base::string16 FullName() const;
// Returns the middle initial if |middle_| is non-empty. Returns an empty
// string otherwise.
base::string16 MiddleInitial() const;
- const base::string16& first() const { return first_; }
- const base::string16& middle() const { return middle_; }
- const base::string16& last() const { return last_; }
-
- // Sets |first_|, |middle_|, and |last_| to the tokenized |full|.
- // It is tokenized on a space only.
+ // Sets |given_|, |middle_|, and |family_| to the tokenized |full|.
void SetFullName(const base::string16& full);
- base::string16 first_;
+ base::string16 given_;
base::string16 middle_;
- base::string16 last_;
+ base::string16 family_;
+ base::string16 full_;
};
class EmailInfo : public FormGroup {
« no previous file with comments | « components/autofill/core/browser/autofill_profile_unittest.cc ('k') | components/autofill/core/browser/contact_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698