Fill in more name fields with requestAutocomplete

chrome/browser/ui/autofill/autofill_dialog_common.cc

Index: chrome/browser/ui/autofill/autofill_dialog_common.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_common.cc b/chrome/browser/ui/autofill/autofill_dialog_common.cc
index 18c844adb63b805701e93588bb86fd01b166c22a..8d92994097395c7d4e31d826a104e349802d090f 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_common.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_common.cc
@@ -42,6 +42,10 @@ bool ServerTypeEncompassesFieldType(ServerFieldType type,
     return autofill_type.GetStorableType() == ADDRESS_HOME_STREET_ADDRESS;
   }
 
+  // First and last name are parsed from full name.
+  if (field_type.group() == NAME || field_type.group() == NAME_BILLING)
+    return autofill_type.GetStorableType() == NAME_FULL;

[Ilya Sherman, 2014/06/03 22:53:34]

Why is this needed?  Shouldn't the NameInfo class handle this internally,
parsing when necessary, but not overridding user-set preferences?  (I guess for
rAc there's currently no way for a user to set anything other than a full name;
but for Autofill there is, so NameInfo should already handle this.  Once it
handles things automatically, I'd rather not add the extra code here.)

[Evan Stade, 2014/06/03 23:55:34]

rAc intentionally only fills in a subset of autocomplete types. That subset is
defined as the fields that are in the dialog. This function slightly expands
that set. |type| is the type that's in the dialog, and |field_type| is something
in the page. So this makes sure that when filling in the page, name fields are
filled in because they line up with the NAME_FULL <input> in the dialog.

[Ilya Sherman, 2014/06/04 00:13:45]

Ah, right.  Makes sense.

+
   return autofill_type.GetStorableType() == server_type;
 }