Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: components/autofill/core/browser/contact_info_unittest.cc

Issue 310463005: Fill in more name fields with requestAutocomplete (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: abuse SetRawInfo Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/contact_info.h" 5 #include "components/autofill/core/browser/contact_info.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "components/autofill/core/browser/autofill_type.h" 10 #include "components/autofill/core/browser/autofill_type.h"
11 #include "components/autofill/core/browser/field_types.h" 11 #include "components/autofill/core/browser/field_types.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 using base::ASCIIToUTF16; 14 using base::ASCIIToUTF16;
15 15
16 namespace autofill { 16 namespace autofill {
17 17
18 struct FullNameTestCase {
19 std::string full_name_input;
20 std::string given_name_output;
21 std::string middle_name_output;
22 std::string family_name_output;
23 } full_name_test_cases[] = {
24 { "", "", "", "" },
25 { "John Smith", "John", "", "Smith" },
26 { "Julien van der Poel", "Julien", "", "van der Poel" },
27 { "John J Johnson", "John", "J", "Johnson" },
28 { "John Smith, Jr.", "John", "", "Smith" },
29 { "Mr John Smith", "John", "", "Smith" },
30 { "Mr. John Smith", "John", "", "Smith" },
31 { "Mr. John Smith, M.D.", "John", "", "Smith" },
32 { "Mr. John Smith, MD", "John", "", "Smith" },
33 { "John Jacob Jingleheimer Smith", "John Jacob", "Jingleheimer", "Smith" },
34 { "Virgil", "Virgil", "", "" },
35 { "Murray Gell-Mann", "Murray", "", "Gell-Mann" },
36 { "Mikhail Yevgrafovich Saltykov-Shchedrin", "Mikhail", "Yevgrafovich",
37 "Saltykov-Shchedrin" },
38 { "Arthur Ignatius Conan Doyle", "Arthur Ignatius", "Conan", "Doyle" },
39 };
40
18 TEST(NameInfoTest, SetFullName) { 41 TEST(NameInfoTest, SetFullName) {
19 NameInfo name; 42 for (size_t i = 0; i < arraysize(full_name_test_cases); ++i) {
20 name.SetRawInfo(NAME_FULL, ASCIIToUTF16("Virgil")); 43 const FullNameTestCase& test_case = full_name_test_cases[i];
21 EXPECT_EQ(name.GetRawInfo(NAME_FIRST), ASCIIToUTF16("Virgil")); 44 SCOPED_TRACE(test_case.full_name_input);
22 EXPECT_EQ(name.GetRawInfo(NAME_MIDDLE), base::string16());
23 EXPECT_EQ(name.GetRawInfo(NAME_LAST), base::string16());
24 EXPECT_EQ(name.GetRawInfo(NAME_FULL), ASCIIToUTF16("Virgil"));
25 45
26 name.SetRawInfo(NAME_FULL, ASCIIToUTF16("Murray Gell-Mann")); 46 NameInfo name;
27 EXPECT_EQ(name.GetRawInfo(NAME_FIRST), ASCIIToUTF16("Murray")); 47 name.SetInfo(AutofillType(NAME_FULL),
28 EXPECT_EQ(name.GetRawInfo(NAME_MIDDLE), base::string16()); 48 ASCIIToUTF16(test_case.full_name_input),
29 EXPECT_EQ(name.GetRawInfo(NAME_LAST), ASCIIToUTF16("Gell-Mann")); 49 "en-US");
30 EXPECT_EQ(name.GetRawInfo(NAME_FULL), ASCIIToUTF16("Murray Gell-Mann")); 50 EXPECT_EQ(ASCIIToUTF16(test_case.given_name_output),
31 51 name.GetInfo(AutofillType(NAME_FIRST), "en-US"));
32 name.SetRawInfo(NAME_FULL, 52 EXPECT_EQ(ASCIIToUTF16(test_case.middle_name_output),
33 ASCIIToUTF16("Mikhail Yevgrafovich Saltykov-Shchedrin")); 53 name.GetInfo(AutofillType(NAME_MIDDLE), "en-US"));
34 EXPECT_EQ(name.GetRawInfo(NAME_FIRST), ASCIIToUTF16("Mikhail")); 54 EXPECT_EQ(ASCIIToUTF16(test_case.family_name_output),
35 EXPECT_EQ(name.GetRawInfo(NAME_MIDDLE), ASCIIToUTF16("Yevgrafovich")); 55 name.GetInfo(AutofillType(NAME_LAST), "en-US"));
36 EXPECT_EQ(name.GetRawInfo(NAME_LAST), ASCIIToUTF16("Saltykov-Shchedrin")); 56 EXPECT_EQ(ASCIIToUTF16(test_case.full_name_input),
37 EXPECT_EQ(name.GetRawInfo(NAME_FULL), 57 name.GetInfo(AutofillType(NAME_FULL), "en-US"));
38 ASCIIToUTF16("Mikhail Yevgrafovich Saltykov-Shchedrin")); 58 }
39
40 name.SetRawInfo(NAME_FULL, ASCIIToUTF16("Arthur Ignatius Conan Doyle"));
41 EXPECT_EQ(name.GetRawInfo(NAME_FIRST), ASCIIToUTF16("Arthur"));
42 EXPECT_EQ(name.GetRawInfo(NAME_MIDDLE), ASCIIToUTF16("Ignatius Conan"));
43 EXPECT_EQ(name.GetRawInfo(NAME_LAST), ASCIIToUTF16("Doyle"));
44 EXPECT_EQ(name.GetRawInfo(NAME_FULL),
45 ASCIIToUTF16("Arthur Ignatius Conan Doyle"));
46 } 59 }
47 60
48 TEST(NameInfoTest, GetFullName) { 61 TEST(NameInfoTest, GetFullName) {
49 NameInfo name; 62 NameInfo name;
50 name.SetRawInfo(NAME_FIRST, ASCIIToUTF16("First")); 63 name.SetRawInfo(NAME_FIRST, ASCIIToUTF16("First"));
51 name.SetRawInfo(NAME_MIDDLE, base::string16()); 64 name.SetRawInfo(NAME_MIDDLE, base::string16());
52 name.SetRawInfo(NAME_LAST, base::string16()); 65 name.SetRawInfo(NAME_LAST, base::string16());
53 EXPECT_EQ(name.GetRawInfo(NAME_FIRST), ASCIIToUTF16("First")); 66 EXPECT_EQ(name.GetRawInfo(NAME_FIRST), ASCIIToUTF16("First"));
54 EXPECT_EQ(name.GetRawInfo(NAME_MIDDLE), base::string16()); 67 EXPECT_EQ(name.GetRawInfo(NAME_MIDDLE), base::string16());
55 EXPECT_EQ(name.GetRawInfo(NAME_LAST), base::string16()); 68 EXPECT_EQ(name.GetRawInfo(NAME_LAST), base::string16());
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 name.SetRawInfo(NAME_FIRST, ASCIIToUTF16("First")); 111 name.SetRawInfo(NAME_FIRST, ASCIIToUTF16("First"));
99 name.SetRawInfo(NAME_MIDDLE, ASCIIToUTF16("Middle")); 112 name.SetRawInfo(NAME_MIDDLE, ASCIIToUTF16("Middle"));
100 name.SetRawInfo(NAME_LAST, ASCIIToUTF16("Last")); 113 name.SetRawInfo(NAME_LAST, ASCIIToUTF16("Last"));
101 EXPECT_EQ(name.GetRawInfo(NAME_FIRST), ASCIIToUTF16("First")); 114 EXPECT_EQ(name.GetRawInfo(NAME_FIRST), ASCIIToUTF16("First"));
102 EXPECT_EQ(name.GetRawInfo(NAME_MIDDLE), ASCIIToUTF16("Middle")); 115 EXPECT_EQ(name.GetRawInfo(NAME_MIDDLE), ASCIIToUTF16("Middle"));
103 EXPECT_EQ(name.GetRawInfo(NAME_LAST), ASCIIToUTF16("Last")); 116 EXPECT_EQ(name.GetRawInfo(NAME_LAST), ASCIIToUTF16("Last"));
104 EXPECT_EQ(name.GetRawInfo(NAME_FULL), ASCIIToUTF16("First Middle Last")); 117 EXPECT_EQ(name.GetRawInfo(NAME_FULL), ASCIIToUTF16("First Middle Last"));
105 } 118 }
106 119
107 } // namespace autofill 120 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698