Fill in more name fields with requestAutocomplete

components/autofill/core/browser/contact_info.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_CONTACT_INFO_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_CONTACT_INFO_H_
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 23 matching lines @@
       ServerFieldTypeSet* supported_types) const OVERRIDE;
 
   // Returns the full name, which can include up to the first, middle, and last
   // name.
   base::string16 FullName() const;
 
   // Returns the middle initial if |middle_| is non-empty.  Returns an empty
   // string otherwise.
   base::string16 MiddleInitial() const;
 
-  const base::string16& first() const { return first_; }
-  const base::string16& middle() const { return middle_; }
-  const base::string16& last() const { return last_; }
-
   // Sets |first_|, |middle_|, and |last_| to the tokenized |full|.
-  // It is tokenized on a space only.
   void SetFullName(const base::string16& full);
 
   base::string16 first_;
   base::string16 middle_;
   base::string16 last_;
+  base::string16 full_name_;

[Ilya Sherman, 2014/06/03 22:53:35]

Are you planning to persist this to the database and to Sync it?

[Evan Stade, 2014/06/03 23:55:35]

hrkk.. that would be ideal, yes. I gather that will require more changes. Since
you've probably been the one to handle all database updates for the last N
years, do you have a link to a patch you've done in the past that can serve as
an example for how to do this?

[Ilya Sherman, 2014/06/04 00:13:45]

Rouslan was actually the last one to make such a change:
https://codereview.chromium.org/212873003

 };
 
 class EmailInfo : public FormGroup {
  public:
   EmailInfo();
   EmailInfo(const EmailInfo& info);
   virtual ~EmailInfo();
 
   EmailInfo& operator=(const EmailInfo& info);
 
@@ skipping 27 matching lines @@
   // FormGroup:
   virtual void GetSupportedTypes(
       ServerFieldTypeSet* supported_types) const OVERRIDE;
 
   base::string16 company_name_;
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_CONTACT_INFO_H_