Fill in more name fields with requestAutocomplete

components/webdata/common/web_database_migration_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/guid.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 238 matching lines @@
   //   > .output version_nn.sql
   //   > .dump
   void LoadDatabase(const base::FilePath::StringType& file);
 
  private:
   base::ScopedTempDir temp_dir_;
 
   DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest);
 };
 
-const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 56;
+const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 57;
 
 void WebDatabaseMigrationTest::LoadDatabase(
     const base::FilePath::StringType& file) {
   std::string contents;
   ASSERT_TRUE(GetWebDatabaseData(base::FilePath(file), &contents));
 
   sql::Connection connection;
   ASSERT_TRUE(connection.Open(GetDatabasePath()));
   ASSERT_TRUE(connection.Execute(contents.data()));
 }
@@ skipping 2393 matching lines @@
     EXPECT_EQ(base::string16(), s_profiles.ColumnString16(7));
     EXPECT_EQ(ASCIIToUTF16("US"), s_profiles.ColumnString16(8));
     EXPECT_EQ(1395948829, s_profiles.ColumnInt(9));
     EXPECT_EQ(ASCIIToUTF16("Chrome settings"), s_profiles.ColumnString16(10));
     EXPECT_EQ(std::string(), s_profiles.ColumnString(11));
 
     // No more entries expected.
     ASSERT_FALSE(s_profiles.Step());
   }
 }
+
+// Tests that migrating from version 56 to version 57 adds the full_name
+// column to autofill_profile_names table.
+TEST_F(WebDatabaseMigrationTest, MigrateVersion56ToCurrent) {
+  ASSERT_NO_FATAL_FAILURE(LoadDatabase(FILE_PATH_LITERAL("version_56.sql")));
+
+  // Verify pre-conditions. These are expectations for version 56 of the
+  // database.
+  {
+    sql::Connection connection;
+    ASSERT_TRUE(connection.Open(GetDatabasePath()));
+    ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection));
+
+    EXPECT_FALSE(
+        connection.DoesColumnExist("autofill_profile_names", "full_name"));

[Ilya Sherman, 2014/06/12 23:25:25]

I'd prefer that you also verify that the table starts with exactly one name,
"Jon Smith".  Otherwise, the test could be dropping names and still passing.

[Evan Stade, 2014/06/14 01:17:24]

Done.

+  }
+
+  DoMigration();
+
+  // Verify post-conditions. These are expectations for current version of the
+  // database.
+  {
+    sql::Connection connection;
+    ASSERT_TRUE(connection.Open(GetDatabasePath()));
+    ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection));
+
+    // Check version.
+    EXPECT_EQ(kCurrentTestedVersionNumber, VersionFromConnection(&connection));
+
+    // The language_code column should have been added to autofill_profiles
+    // table.

[Ilya Sherman, 2014/06/12 23:25:25]

nit: Please update this comment.

[Evan Stade, 2014/06/14 01:17:23]

Done.

+    EXPECT_TRUE(
+        connection.DoesColumnExist("autofill_profile_names", "full_name"));
+
+    // Data should have been preserved. Full name should have been set to the
+    // empty string.
+    sql::Statement s_names(
+        connection.GetUniqueStatement(
+            "SELECT guid, first_name, middle_name, last_name, full_name "
+            "FROM autofill_profile_names"));
+
+    ASSERT_TRUE(s_names.Step());
+    EXPECT_EQ("B41FE6E0-B13E-2A2A-BF0B-29FCE2C3ADBD", s_names.ColumnString(0));
+    EXPECT_EQ(ASCIIToUTF16("Jon"), s_names.ColumnString16(1));
+    EXPECT_EQ(ASCIIToUTF16(""), s_names.ColumnString16(2));
+    EXPECT_EQ(ASCIIToUTF16("Smith"), s_names.ColumnString16(3));
+    EXPECT_EQ(ASCIIToUTF16(""), s_names.ColumnString16(4));

[Ilya Sherman, 2014/06/12 23:25:25]

nit: "base::string16()" is generally preferred over "ASCIIToUTF16("")".

[Evan Stade, 2014/06/14 01:17:23]

Done.

+
+    // No more entries expected.
+    ASSERT_FALSE(s_names.Step());
+  }
+}