Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: LayoutTests/inspector/sources/debugger/breakpoint-manager.html

Issue 310463003: DevTools: introduce TargetBreakpoints as a presentation of breakpoint and its state within target (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address vsevik's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/sources/debugger/breakpoint-manager.html
diff --git a/LayoutTests/inspector/sources/debugger/breakpoint-manager.html b/LayoutTests/inspector/sources/debugger/breakpoint-manager.html
index 5ad79ab181e7341eed2e4f662b00f898fe8829d1..e250411c87e9e0a683573e51876eaa98b458691c 100644
--- a/LayoutTests/inspector/sources/debugger/breakpoint-manager.html
+++ b/LayoutTests/inspector/sources/debugger/breakpoint-manager.html
@@ -15,10 +15,8 @@ function test()
return 1;
}
};
- var targetManager = {
- targets: function () { return [mockTarget]},
- observeTargets: function() {}
- }
+ var targetManager = new WebInspector.TargetManager();
+ targetManager._targets.push(mockTarget);
var defaultMapping = {
rawLocationToUILocation: function(rawLocation)
@@ -213,11 +211,6 @@ function test()
}
DebuggerModelMock.prototype.__proto__ = WebInspector.Object.prototype;
- var dummySetting = {
- get: function() { return []; },
- set: function(breakpoints) { }
- };
-
function resetWorkspace(breakpointManager)
{
InspectorTest.addResult(" Resetting workspace.");
@@ -294,8 +287,6 @@ function test()
var debuggerModel = new DebuggerModelMock(sourceMapping);
workspace = new WebInspector.Workspace();
var breakpointManager = new WebInspector.BreakpointManager(setting, workspace, targetManager);
- mockTarget.debuggerModel = debuggerModel;
- breakpointManager.targetAdded(mockTarget);
breakpointManager._networkWorkspaceBinding = new WebInspector.NetworkWorkspaceBinding(workspace);
breakpointManager._debuggerProjectDelegate = new WebInspector.DebuggerProjectDelegate(workspace, "debugger:", WebInspector.projectTypes.Debugger);
breakpointManager.addEventListener(WebInspector.BreakpointManager.Events.BreakpointAdded, breakpointAdded);
@@ -358,7 +349,7 @@ function test()
dumpBreakpointStorage(breakpointManager);
InspectorTest.addResult(" Resetting breakpoint manager");
breakpointManager.removeAllBreakpoints();
- breakpointManager.removeProvisionalBreakpointsForTest(mockTarget);
+ breakpointManager.removeProvisionalBreakpointsForTest();
uiSourceCodes = {};
next();
}

Powered by Google App Engine
This is Rietveld 408576698