DevTools: introduce TargetBreakpoints as a presentation of breakpoint and its state within target

Source/devtools/front_end/sdk/DebuggerModel.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 30 matching lines @@
     this._agent = target.debuggerAgent();
 
     /** @type {?WebInspector.DebuggerPausedDetails} */
     this._debuggerPausedDetails = null;
     /** @type {!Object.<string, !WebInspector.Script>} */
     this._scripts = {};
     /** @type {!StringMap.<!Array.<!WebInspector.Script>>} */
     this._scriptsBySourceURL = new StringMap();
 
     this._breakpointsActive = true;
+    /** @type {!StringMap.<!WebInspector.DebuggerModel.BreakpointListener>} */
+    this._breakpointListenerById = new StringMap();

[vsevik, 2014/06/05 15:48:29]

Let's have this._breakpointResolvedEventTarget = new EventTarget() instead.

[sergeyv, 2014/06/06 11:44:53]

Done.

 
     WebInspector.settings.pauseOnExceptionEnabled.addChangeListener(this._pauseOnExceptionStateChanged, this);
     WebInspector.settings.pauseOnCaughtException.addChangeListener(this._pauseOnExceptionStateChanged, this);
 
     WebInspector.settings.enableAsyncStackTraces.addChangeListener(this._asyncStackTracesStateChanged, this);
     target.profilingLock.addEventListener(WebInspector.Lock.Events.StateChanged, this._asyncStackTracesStateChanged, this);
 
     this.enableDebugger();
 
     WebInspector.settings.skipStackFramesSwitch.addChangeListener(this._applySkipStackFrameSettings, this);
@@ skipping 12 matching lines @@
     PauseOnUncaughtExceptions: "uncaught"
 };
 
 WebInspector.DebuggerModel.Events = {
     DebuggerWasEnabled: "DebuggerWasEnabled",
     DebuggerWasDisabled: "DebuggerWasDisabled",
     DebuggerPaused: "DebuggerPaused",
     DebuggerResumed: "DebuggerResumed",
     ParsedScriptSource: "ParsedScriptSource",
     FailedToParseScriptSource: "FailedToParseScriptSource",
-    BreakpointResolved: "BreakpointResolved",
     GlobalObjectCleared: "GlobalObjectCleared",
     CallFrameSelected: "CallFrameSelected",
     ConsoleCommandEvaluatedInSelectedCallFrame: "ConsoleCommandEvaluatedInSelectedCallFrame",
     BreakpointsActiveStateChanged: "BreakpointsActiveStateChanged"
 }
 
 WebInspector.DebuggerModel.BreakReason = {
     DOM: "DOM",
     EventListener: "EventListener",
     XHR: "XHR",
@@ skipping 229 matching lines @@
                 callback();
         }
     },
 
     /**
      * @param {!DebuggerAgent.BreakpointId} breakpointId
      * @param {!DebuggerAgent.Location} location
      */
     _breakpointResolved: function(breakpointId, location)
     {
-        this.dispatchEventToListeners(WebInspector.DebuggerModel.Events.BreakpointResolved, {breakpointId: breakpointId, location: WebInspector.DebuggerModel.Location.fromPayload(this.target(), location)});
+        var breakpointListener = this._breakpointListenerById.get(breakpointId);
+        if (breakpointListener) {
+            var debuggerLocation = WebInspector.DebuggerModel.Location.fromPayload(this.target(), location);
+            breakpointListener.breakpointResolved(debuggerLocation)
+        }
     },
 
     _globalObjectCleared: function()
     {
         this._setDebuggerPausedDetails(null);
         this._reset();
         this.dispatchEventToListeners(WebInspector.DebuggerModel.Events.GlobalObjectCleared);
     },
 
     _reset: function()
@@ skipping 355 matching lines @@
         {
             if (error) {
                 console.error(error);
                 callback(null);
                 return;
             }
             callback(response);
         }
     },
 
+    /**
+     * @param {!DebuggerAgent.BreakpointId} breakpointId
+     * @param {!WebInspector.DebuggerModel.BreakpointListener} listener
+     */
+    registerBreakpointListenerForId: function(breakpointId, listener)
+    {
+        this._breakpointListenerById.put(breakpointId, listener);
+    },
+
+    /**
+     * @param {!DebuggerAgent.BreakpointId} breakpointId
+     */
+    unregisterBreakpointListenerForId: function(breakpointId)
+    {
+        this._breakpointListenerById.remove(breakpointId);
+    },
+
     __proto__: WebInspector.TargetAwareObject.prototype
 }
 
 WebInspector.DebuggerEventTypes = {
     JavaScriptPause: 0,
     JavaScriptBreakpoint: 1,
     NativeBreakpoint: 2
 };
 
 /**
@@ skipping 66 matching lines @@
      * @param {!DebuggerAgent.BreakpointId} breakpointId
      * @param {!DebuggerAgent.Location} location
      */
     breakpointResolved: function(breakpointId, location)
     {
         this._debuggerModel._breakpointResolved(breakpointId, location);
     }
 }
 
 /**
+ * @interface
+ */
+WebInspector.DebuggerModel.BreakpointListener = function() {
+}
+
+WebInspector.DebuggerModel.BreakpointListener.prototype = {
+
+    /**
+     * @param {!WebInspector.DebuggerModel.Location} location
+     */
+    breakpointResolved: function(location) { }
+
+}
+
+/**
  * @constructor
  * @implements {WebInspector.RawLocation}
  * @extends {WebInspector.TargetAware}
  * @param {!WebInspector.Target} target
  * @param {string} scriptId
  * @param {number} lineNumber
  * @param {number=} columnNumber
  */
 WebInspector.DebuggerModel.Location = function(target, scriptId, lineNumber, columnNumber)
 {
@@ skipping 325 matching lines @@
             this.asyncStackTrace.dispose();
     },
 
     __proto__: WebInspector.TargetAware.prototype
 }
 
 /**
  * @type {!WebInspector.DebuggerModel}
  */
 WebInspector.debuggerModel;