Fix the aec dump crash when users disable aec dump without closing the "Save File" overlay.

Fix the aec dump crash when users disable aec dump without closing the "Save File" overlay.

BUG=378713
TEST=manual test:
1Launch chrome and navigate to chrome://webrtc-internals/. 
2.Expand "Create Dump" option >> Check the checkbox option of "enable Diagnostic audio recordings". 
3.With "Save File" overlay opened, again uncheck the same checkbox.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274523

[no longer working on chromium, 2014-05-30 10:54:44]

Henrik, PTAL.

[Henrik Grunell, 2014-05-30 11:24:39]

https://codereview.chromium.org/310463002/diff/40001/content/browser/media/we...
File content/browser/media/webrtc_internals.cc (right):

https://codereview.chromium.org/310463002/diff/40001/content/browser/media/we...
content/browser/media/webrtc_internals.cc:249: select_file_dialog_ = NULL;
Add a comment why we do this. (If user unchecks box while dialog still open.)

https://codereview.chromium.org/310463002/diff/40001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_device_impl.cc (right):

https://codereview.chromium.org/310463002/diff/40001/content/renderer/media/w...
content/renderer/media/webrtc_audio_device_impl.cc:528: // Close the previous
AEC dump file description if it has not been consumed.
What is the case when this can happen? Add it to the comment.

[no longer working on chromium, 2014-06-02 08:34:13]

Henrik, PTAL.

Thanks,
SX

https://codereview.chromium.org/310463002/diff/40001/content/browser/media/we...
File content/browser/media/webrtc_internals.cc (right):

https://codereview.chromium.org/310463002/diff/40001/content/browser/media/we...
content/browser/media/webrtc_internals.cc:249: select_file_dialog_ = NULL;
On 2014/05/30 11:24:39, Henrik Grunell wrote:
> Add a comment why we do this. (If user unchecks box while dialog still open.)

Done.

https://codereview.chromium.org/310463002/diff/40001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_device_impl.cc (right):

https://codereview.chromium.org/310463002/diff/40001/content/renderer/media/w...
content/renderer/media/webrtc_audio_device_impl.cc:528: // Close the previous
AEC dump file description if it has not been consumed.
On 2014/05/30 11:24:39, Henrik Grunell wrote:
> What is the case when this can happen? Add it to the comment.

Done.

[no longer working on chromium, 2014-06-02 10:27:56]

Henrik, done with adding a TODO.

[Henrik Grunell, 2014-06-02 11:02:25]

lgtm

[no longer working on chromium, 2014-06-02 11:03:34]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-06-02 11:04:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/310463002/70001

[commit-bot: I haz the power, 2014-06-02 21:07:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-02 21:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-02 21:28:59]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[no longer working on chromium, 2014-06-03 11:50:29]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-06-03 11:50:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/310463002/90001

[commit-bot: I haz the power, 2014-06-03 14:47:09]

Change committed as 274523