Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2314)

Unified Diff: Source/modules/websockets/WebSocketTest.cpp

Issue 310453002: Do not use V8TestingScope::create in WebSocketTest.cpp (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/websockets/WebSocketTest.cpp
diff --git a/Source/modules/websockets/WebSocketTest.cpp b/Source/modules/websockets/WebSocketTest.cpp
index 99c402ba886c83c9c573ee2d0274957cb55dca4a..f534f5a04feca4afa2cd791d101e85e4689815dd 100644
--- a/Source/modules/websockets/WebSocketTest.cpp
+++ b/Source/modules/websockets/WebSocketTest.cpp
@@ -102,8 +102,8 @@ public:
: m_pageHolder(DummyPageHolder::create())
, m_websocket(WebSocketWithMockChannel::create(&m_pageHolder->document()))
, m_channel(m_websocket->channel())
- , m_executionScope(V8TestingScope::create(v8::Isolate::GetCurrent()))
- , m_exceptionState(ExceptionState::ConstructionContext, "property", "interface", m_executionScope->scriptState()->context()->Global(), m_executionScope->isolate())
+ , m_executionScope(v8::Isolate::GetCurrent())
+ , m_exceptionState(ExceptionState::ConstructionContext, "property", "interface", m_executionScope.scriptState()->context()->Global(), m_executionScope.isolate())
{
}
@@ -123,7 +123,7 @@ public:
OwnPtr<DummyPageHolder> m_pageHolder;
RefPtrWillBePersistent<WebSocketWithMockChannel> m_websocket;
RefPtrWillBePersistent<MockWebSocketChannel> m_channel;
- OwnPtr<V8TestingScope> m_executionScope;
+ V8TestingScope m_executionScope;
ExceptionState m_exceptionState;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698