Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: Source/core/html/HTMLStyleElement.h

Issue 310443002: Remove scoped styles. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix layout test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLStyleElement.h
diff --git a/Source/core/html/HTMLStyleElement.h b/Source/core/html/HTMLStyleElement.h
index d7ddd8843691774c169127de43be427b4f2a88d1..a89dcb8c273cad5ebbeb95c93139b6aa96408386 100644
--- a/Source/core/html/HTMLStyleElement.h
+++ b/Source/core/html/HTMLStyleElement.h
@@ -42,22 +42,8 @@ public:
void setType(const AtomicString&);
- bool scoped() const;
- void setScoped(bool);
ContainerNode* scopingNode();
- bool isRegisteredAsScoped() const
- {
- // Note: We cannot rely on the 'scoped' attribute still being present when this method is invoked.
- // Therefore we cannot rely on scoped()!
- if (m_scopedStyleRegistrationState == NotRegistered)
- return false;
- return true;
- }
-
- bool isRegisteredInShadowRoot() const
- {
- return m_scopedStyleRegistrationState == RegisteredInShadowRoot;
- }
+ bool isScoped() const { return m_scoped; }
tasak 2014/06/03 05:57:48 I think, it would be beter to do: (a) return isInS
kochi 2014/06/03 07:47:05 I'll take the (b) approach. Less "scope" terminolo
using StyleElement::sheet;
@@ -88,19 +74,9 @@ private:
virtual const AtomicString& media() const OVERRIDE;
virtual const AtomicString& type() const OVERRIDE;
- void scopedAttributeChanged(bool);
- void registerWithScopingNode(bool);
- void unregisterWithScopingNode(ContainerNode*);
-
bool m_firedLoad;
bool m_loadedSheet;
-
- enum ScopedStyleRegistrationState {
- NotRegistered,
- RegisteredAsScoped,
- RegisteredInShadowRoot
- };
- ScopedStyleRegistrationState m_scopedStyleRegistrationState;
+ bool m_scoped;
tasak 2014/06/03 05:57:48 We still need m_scoped? I think, we could replace
kochi 2014/06/03 07:47:05 Removed.
};
} //namespace

Powered by Google App Engine
This is Rietveld 408576698