Gallery.app: Update thumbnail when a file is edited on the photo editor.

Gallery.app: Update thumbnail when a file is edited on the photo editor.

This CL do followings to ensure to update thumbnails after the app saves images.

* Add '?nocache=xxx' to FileEntry's URL to ignore browser caches.
* Stop to use drive thumbnails for files that are on the drive but cached
  locally. These files may be edited locally and be out of sync with the local
  cache.
* Specify the current time as modificationTime of the metadata that is
  dispatched when the edited file is saved.

BUG=378648
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274506

[hirono, 2014-05-30 12:20:39]

PTAL the CL? Thank you!

[mtomasz, 2014-06-02 06:40:28]

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/media/media_util.js (right):

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/media/media_util.js:194: // need to
force to update of the file.
Please note that this is a workaround for a bug. It has a side effect, that we
lose thumbnails for drive files when offline.

See: crbug.com/367697

How about invalidating the cache once the file is changed in the photo editor.
It is still a workaround, but wouldn't harm offline so much.

https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/im...

WDYT?

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:494: this.image_.src =
entry.toURL() + "?nocache=" + Date.now();
Does it happen on Downloads too? If so, then it seems to be a serious regression
in either Chromium or Blink. We should file a bug for it.

[hirono, 2014-06-02 08:59:15]

Thank you!

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/media/media_util.js (right):

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/media/media_util.js:194: // need to
force to update of the file.
On 2014/06/02 06:40:28, mtomasz wrote:
> Please note that this is a workaround for a bug. It has a side effect, that we
> lose thumbnails for drive files when offline.
> 
> See: crbug.com/367697
> 
> How about invalidating the cache once the file is changed in the photo editor.
> It is still a workaround, but wouldn't harm offline so much.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/im...
> 
> WDYT?

I changed the code so that the app invalidates the cache.
Thank you!

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:494: this.image_.src =
entry.toURL() + "?nocache=" + Date.now();
On 2014/06/02 06:40:28, mtomasz wrote:
> Does it happen on Downloads too? If so, then it seems to be a serious
regression
> in either Chromium or Blink. We should file a bug for it.

Yes it happens to Downloads too.
Filed: crbug.com/379678

[mtomasz, 2014-06-03 05:33:19]

According to crbug.com/346625, Drive last modification time should be already
fixed on ToT. Please check, and maybe we will not need one of workarounds in
this patch.

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:494: this.image_.src =
entry.toURL() + "?nocache=" + Date.now();
On 2014/06/02 08:59:15, hirono wrote:
> On 2014/06/02 06:40:28, mtomasz wrote:
> > Does it happen on Downloads too? If so, then it seems to be a serious
> regression
> > in either Chromium or Blink. We should file a bug for it.
> 
> Yes it happens to Downloads too.
> Filed: crbug.com/379678

Please write a comment that it is a workaround, and the proper fix is tracked at
crbug.com/379678. Otherwise, we will never remove this workaround.

[hirono, 2014-06-03 07:51:45]

The metadata on the drive is fixed.
It works fine without workaround.

Thank you!

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/310433004/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:494: this.image_.src =
entry.toURL() + "?nocache=" + Date.now();
On 2014/06/03 05:33:19, mtomasz wrote:
> On 2014/06/02 08:59:15, hirono wrote:
> > On 2014/06/02 06:40:28, mtomasz wrote:
> > > Does it happen on Downloads too? If so, then it seems to be a serious
> > regression
> > > in either Chromium or Blink. We should file a bug for it.
> > 
> > Yes it happens to Downloads too.
> > Filed: crbug.com/379678
> 
> Please write a comment that it is a workaround, and the proper fix is tracked
at
> crbug.com/379678. Otherwise, we will never remove this workaround.

Done.

[mtomasz, 2014-06-03 07:52:27]

Thanks! LGTM.

[hirono, 2014-06-03 07:52:38]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-06-03 07:54:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/310433004/60001

[commit-bot: I haz the power, 2014-06-03 13:27:10]

Change committed as 274506